Ped Randomizer: Allow specifying multiple models in ForcePed#35
Open
pongo1231 wants to merge 2 commits into
Open
Ped Randomizer: Allow specifying multiple models in ForcePed#35pongo1231 wants to merge 2 commits into
pongo1231 wants to merge 2 commits into
Conversation
Owner
|
Thanks for the pull request, but it makes it so that the ForcedPed config option can't be changed using the debug menu. It'd be better to provide an override for it in the config reading code and the config debug interface code. |
pongo1231
force-pushed
the
forceped_multiple_models
branch
from
54cfa1f to
5c5c0ae
Compare
Collaborator
Author
|
Works with the debug menu now, however right now it'll store a second copy of ForcePed and compare the config's ForcePed each time GetRandomPedModel gets invoked to check if it should update its list of ped hashes, which is not particularly optimal. I couldn't find any other way outside of modifying the config reading logic to include code specific to parsing ForcePed and not keeping it self-contained anymore though. |
pongo1231
force-pushed
the
forceped_multiple_models
branch
from
2640a4d to
4cdfe0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #19