Add performance test infrastructure for Azure Service Bus#1342
Open
Add performance test infrastructure for Azure Service Bus#1342
Conversation
| client.DisposeAsync().AsTask().GetAwaiter().GetResult(); | ||
| } | ||
|
|
||
| static string Sanitize(string name) |
Contributor
There was a problem hiding this comment.
I think we have a sanitize helper you could include as code and then use it
| } | ||
| } | ||
|
|
||
| internal static partial void EnsureQueueExists(string queueName, int maxDepth) |
Contributor
There was a problem hiding this comment.
Could we make all the IO-bound methods async by returning Task or ValueTask?
Contributor
danielmarbach
left a comment
danielmarbach
left a comment
There was a problem hiding this comment.
I think it would benefit from some small instructions in the readme on when to run those and what to expect
Member
Author
Will update this at later stage, have been adding other fixes after more testing with IBMQMQ. If those are in the next alpha, I'll update this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the new NuGet Sources package created here: https://github.com/Particular/NServiceBus.PerformanceTests