Do not return negative throughput when queue table deleted#5404
Merged
mikeminutillo merged 1 commit intomasterfrom Apr 15, 2026
Merged
Do not return negative throughput when queue table deleted#5404mikeminutillo merged 1 commit intomasterfrom
mikeminutillo merged 1 commit intomasterfrom
Conversation
Member
Author
|
This is in alignment with how the Endpoint Throughput Counter tool does it. |
PhilBastian
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While calculating throughput, when a queue table is deleted, we see a negative throughput entry recorded in the usage report for the day.
This happens because we take two snapshots, an hour apart, and then this to figure out how many messages have been processed:
When a table gets deleted, we do not set the
totalMessagesEndOfHourwhich results in the default value of zero. This ends up looking like this:That is always going to be a negative number, and one that is not representative of the throughput in that hour.