Merged
Conversation
This makes it possible to not store the secret in the configuration file itself, allowing to pass it in via different mechanisms (like systemd service credentials) without having to assemble JSON at runtime. jwt_secret is still accepted, and used in most tests, but jwt_secret_path is preferred.
flokli
force-pushed
the
jwt-secret-path
branch
from
53c03cd to
b79ff81
Compare
flokli
changed the title
Owner
|
Thanks for a very appropriate change (again)! I could indeed remove jwt_secret, now that I woke up from my hibernation with this project :-). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to not store the secret in the configuration file itself, allowing to pass it in via different mechanisms (like systemd service credentials) without having to assemble JSON at runtime.
jwt_secret is still accepted, and used in most tests, but jwt_path is preferred.