Skip to content

Speeding up creation of bookmark nodes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RealMalWare wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Speeding up creation of bookmark nodes #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions BookmarksViewer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace Patagames.Pdf.Net.Controls.WinForms
/// </summary>
public partial class BookmarksViewer : TreeView
{
private const string TreeNodeLoadingKey = "{C5C14465-60FB-448D-A3BD-8F5E855C081D}";

#region Private fields
private PdfViewer _pdfViewer = null;
Expand Down Expand Up @@ -106,7 +107,7 @@ protected virtual void OnPdfViewerChanging(PdfViewer oldValue, PdfViewer newValu
/// <param name="e"></param>
protected override void OnBeforeExpand(TreeViewCancelEventArgs e)
{
if (e.Node.Nodes.Count == 1 && e.Node.Nodes.ContainsKey("{C5C14465-60FB-448D-A3BD-8F5E855C081D}"))
if (e.Node.Nodes.Count == 1 && e.Node.Nodes.ContainsKey(TreeNodeLoadingKey))
{
e.Node.Nodes.Clear();
BuildTree(e.Node.Nodes, (e.Node as BookmarksViewerNode).Bookmark.Childs);
Expand Down Expand Up @@ -161,16 +162,18 @@ private void BuildTree(TreeNodeCollection nodes, PdfBookmarkCollections bookmark
if (bookmarks == null)
return;

var nodeList = new List<TreeNode>();
foreach (var b in bookmarks)
{
if (_processed.ContainsKey(b.Handle))
continue;
_processed.Add(b.Handle, 1);
var node = new BookmarksViewerNode(b);
nodes.Add(node);
if (b.Childs != null && b.Childs.Count > 0)
node.Nodes.Add("{C5C14465-60FB-448D-A3BD-8F5E855C081D}", "Loading...");
node.Nodes.Add(TreeNodeLoadingKey, "Loading...");
nodeList.Add(node);
}
nodes.AddRange(nodeList.ToArray());
}
#endregion

Expand Down