Skip to content

refactor: split play file into types, api, and component #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patai5 merged 2 commits into from
Jul 13, 2025
Merged

refactor: split play file into types, api, and component #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72f9837
refactor: split play file into types, api, and component
Patai5 Jul 13, 2025
eacc00c
test(unit): add play game tests
Patai5 Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
213 changes: 12 additions & 201 deletions frontend/src/components/Play/Play.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,14 @@
/** @jsxImportSource @emotion/react */
import { css } from "@emotion/react";
import { PlayersProps as PlayersAPI } from "components/shared/Chess/ActionBar/ActionBar";
import Chess, { PlayersProps } from "components/shared/Chess/Chess";
import { Move, MoveInfo, MoveName } from "components/shared/Chess/ChessBoard/ChessLogic/board";
import Chess from "components/shared/Chess/Chess";
import { Color } from "components/shared/Chess/ChessBoard/ChessLogic/pieces";
import { useChessBoardState } from "components/shared/Chess/useChessBoardState/useChessBoardState";
import { ErrorQueueClass } from "components/shared/ErrorQueue/ErrorQueue";
import Loading from "components/shared/Loading";
import UserMenu from "components/shared/UserMenu/UserMenu";
import { AppContext } from "hooks/appContext";
import React from "react";
import { useParams } from "react-router-dom";
import { GameResultApiResponse } from "types/api/gameResult";
import { validateId } from "utils/chess";
import { getWSUri } from "utils/websockets";

const ColorName = { white: Color.White, black: Color.Black };
interface JoinAPIResponse {
players: PlayersProps;
moves: MoveName[];
offer_draw: boolean;
game_started: boolean;
}

interface MoveAPIResponse {
move: MoveName;
players: PlayersAPI;
}

interface GameStartedAPIResponse {
players: PlayersAPI;
}
import { CONNECTION_STATE, usePlayApi } from "./usePlayApi";

const playCss = css`
display: flex;
Expand All @@ -39,188 +17,21 @@ const playCss = css`
height: 100%;
`;

const enum ConnectingState {
Connecting,
Connected,
Error,
}

export default function Play() {
const [connectingState, setConnectingState] = React.useState(ConnectingState.Connecting);
const [color, setColor] = React.useState<Color>(Color.White);
const [gameResult, setGameResult] = React.useState<GameResultApiResponse | null>(null);
const [highlightDrawButton, setHighlightDrawButton] = React.useState(false);
const [gameStarted, setGameStarted] = React.useState(true);
const [players, setPlayers] = React.useState<PlayersProps | null>(null);

const appContext = React.useContext(AppContext);
const { username: clientUsername } = appContext;

const ws = React.useRef<WebSocket | null>(null);
const clientUsername = React.useRef(appContext.username);
const [color, setColor] = React.useState<Color>(Color.White);
const [gameStarted, setGameStarted] = React.useState(true);

const chessBoardStateHandlers = useChessBoardState({ color: color, isEnabled: gameStarted });
const chessBoardStateHandlers = useChessBoardState({ color, isEnabled: gameStarted });
const { handleClientMakeMove } = chessBoardStateHandlers;

const { id } = useParams();

React.useEffect(() => {
clientUsername.current = appContext.username;
}, [appContext.username]);

const setError = (error: string) => {
ErrorQueueClass.addError({ errorMessage: error });
setConnectingState(ConnectingState.Error);
};

const handleGameIdValidation = (): boolean => {
const isValidId = validateId(id);
if (isValidId !== true) {
setError(isValidId);
return false;
}
return true;
};

const broadcastMove = (move: MoveInfo) => {
setHighlightDrawButton(false);
sendMessage(JSON.stringify({ type: "move", move: move.toName() }));
};

const handleOnMessage = (msg: MessageEvent) => {
const data = JSON.parse(msg.data);
switch (data.type) {
case "join":
handleJoined(data);
break;
case "game_started":
handleGameStarted(data);
break;
case "move":
handleMove(data);
break;
case "game_result":
handleGameResult(data);
break;
case "offer_draw":
handleReceivedDrawOffer();
break;
case "error":
ErrorQueueClass.addError({ errorMessage: data.message });
setConnectingState(ConnectingState.Error);
break;
default:
ErrorQueueClass.addError({ errorMessage: `Unknown message type received: ${data.type}` });
}
};

const handleResign = () => {
sendMessage(JSON.stringify({ type: "resign" }));
};

const handleOfferDraw = () => {
sendMessage(JSON.stringify({ type: "offer_draw" }));
};

const handleReceivedDrawOffer = () => {
setHighlightDrawButton(true);
};

const updatePlayersFromAPI = (playersAPI: PlayersAPI) => {
const playersProps = {} as PlayersProps;
for (const [color, player] of Object.entries(playersAPI)) {
playersProps[ColorName[color as "white" | "black"]] = {
...player,
};
}
setPlayers(playersProps);
};

const updateMove = (moveName: MoveName) => {
const { move, promotionPiece } = Move.fromName(moveName);
handleClientMakeMove(move, promotionPiece);
};

const handleMove = (data: MoveAPIResponse) => {
setHighlightDrawButton(false);
updatePlayersFromAPI(data.players);
updateMove(data.move);
};

const handleGameResult = (data: GameResultApiResponse) => {
setHighlightDrawButton(false);
setGameResult({
winner: data.winner,
termination: data.termination,
});
};

const handleJoined = (data: JoinAPIResponse) => {
if (!clientUsername.current) return setError("Username is not set");

for (const [color, player] of Object.entries(data.players)) {
if (player.username === clientUsername.current) {
setColor(ColorName[color as "white" | "black"]);
}
}
updatePlayersFromAPI(data.players);

for (const move of data.moves) {
updateMove(move);
}

setGameStarted(data.game_started);
setHighlightDrawButton(data.offer_draw);

setConnectingState(ConnectingState.Connected);
};

const joinGame = () => {
sendMessage(
JSON.stringify({
type: "join",
game_id: id,
}),
);
};

const handleGameStarted = (data: GameStartedAPIResponse) => {
setGameStarted(true);
updatePlayersFromAPI(data.players);
};

const sendMessage = (msg: string) => {
if (!ws.current || ws.current.readyState !== ws.current.OPEN) {
setError("Not connected to server");
return;
}
ws.current.send(msg);
};

React.useEffect(() => {
if (!handleGameIdValidation()) return;
if (ws.current) return;

const createWs = new WebSocket(getWSUri() + "/api/play/" + id);

createWs.onopen = () => {
ws.current = createWs;
joinGame();
};
createWs.onmessage = (e) => {
handleOnMessage(e);
};
createWs.onclose = (ev) => {
if (ev.code === 1000) return; // Normal closure
setError("Connection closed - CODE: " + ev.code);
};
createWs.onerror = () => {
setError("Error connecting to server");
};
const { id: gameId } = useParams();

return () => {
if (createWs.readyState === createWs.OPEN) createWs.close();
};
}, []);
const playGameApi = usePlayApi({ gameId, clientUsername, setColor, setGameStarted, handleClientMakeMove });
const { connectionState, players, highlightDrawButton, gameResult, broadcastMove, handleResign, handleOfferDraw } =
playGameApi;

const chessProps = {
color: color,
Expand All @@ -244,8 +55,8 @@ export default function Play() {
<UserMenu />

<div css={playCss}>
{connectingState === ConnectingState.Connecting && <Loading displayText="Connecting" />}
{connectingState === ConnectingState.Connected && <Chess {...chessProps} />}
{connectionState === CONNECTION_STATE.CONNECTING && <Loading displayText="Connecting" />}
{connectionState === CONNECTION_STATE.CONNECTED && <Chess {...chessProps} />}
</div>
</>
);
Expand Down
Loading