Skip to content

Add support for many Rune mods #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Sep 11, 2025
Merged

Add support for many Rune mods #1352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db8ac34
Add support for many Rune mods
Sep 10, 2025
49e8811
Merge branch 'dev' into rune-mods
LocalIdentity Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Data/ModCache.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,7 +1124,7 @@ c["10% increased Thorns damage"]={{[1]={flags=0,keywordFlags=0,name="ThornsDamag
c["10% increased Trap Damage"]={{[1]={flags=0,keywordFlags=4096,name="Damage",type="INC",value=10}},nil}
c["10% increased Warcry Cooldown Recovery Rate"]={{[1]={flags=0,keywordFlags=4,name="CooldownRecovery",type="INC",value=10}},nil}
c["10% increased Weapon Damage per 10 Strength"]={{[1]={[1]={div=10,stat="Str",type="PerStat"},flags=8192,keywordFlags=0,name="Damage",type="INC",value=10}},nil}
c["10% increased Withered Magnitude"]={{}," Withered Magnitude "}
c["10% increased Withered Magnitude"]={{[1]={flags=0,keywordFlags=0,name="WitherEffect",type="INC",value=10}},nil}
c["10% increased amount of Life Leeched"]={{[1]={flags=0,keywordFlags=0,name="MaxLifeLeechRate",type="INC",value=10}},nil}
c["10% increased amount of Mana Leeched"]={{[1]={flags=0,keywordFlags=0,name="MaxManaLeechRate",type="INC",value=10}},nil}
c["10% increased chance to Shock"]={{[1]={flags=0,keywordFlags=0,name="EnemyShockChance",type="INC",value=10}},nil}
Expand Down Expand Up @@ -1831,7 +1831,7 @@ c["20% increased Totem Life"]={{[1]={flags=0,keywordFlags=0,name="TotemLife",typ
c["20% increased Totem Placement range"]={{[1]={flags=0,keywordFlags=16384,name="WeaponRange",type="INC",value=20}}," Placement "}
c["20% increased Totem Placement speed"]={{[1]={flags=0,keywordFlags=0,name="TotemPlacementSpeed",type="INC",value=20}},nil}
c["20% increased Warcry Speed"]={{[1]={flags=0,keywordFlags=4,name="WarcrySpeed",type="INC",value=20}},nil}
c["20% increased Withered Magnitude"]={{}," Withered Magnitude "}
c["20% increased Withered Magnitude"]={{[1]={flags=0,keywordFlags=0,name="WitherEffect",type="INC",value=20}},nil}
c["20% increased amount of Life Leeched"]={{[1]={flags=0,keywordFlags=0,name="MaxLifeLeechRate",type="INC",value=20}},nil}
c["20% increased bonuses gained from Equipped Quiver"]={{[1]={flags=0,keywordFlags=0,name="EffectOfBonusesFromQuiver",type="INC",value=20}},nil}
c["20% increased chance to Shock"]={{[1]={flags=0,keywordFlags=0,name="EnemyShockChance",type="INC",value=20}},nil}
Expand Down
11 changes: 10 additions & 1 deletion src/Modules/ModParser.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ local formList = {
["(%d+) additional hits?"] = "BASE",
["^throw up to (%d+)"] = "BASE",
["^you gain ([%d%.]+)"] = "GAIN",
["^gains? ([%d%.]+)%% of their"] = "GAIN",
["^gains? ([%d%.]+)%% of"] = "GAIN",
["^gains? ([%d%.]+)"] = "GAIN",
["^gain %+(%d+)%% to"] = "GAIN",
Expand Down Expand Up @@ -473,6 +474,7 @@ local modNameList = {
["effect of buffs your ancestor totems grant "] = { "BuffEffect", tag = { type = "SkillName", skillNameList = { "Ancestral Warchief", "Ancestral Protector", "Earthbreaker" } } },
["effect of shrine buffs on you"] = "ShrineBuffEffect",
["effect of withered"] = "WitherEffect",
["withered magnitude"] = "WitherEffect",
["effect of fully broken armour"] = "FullyBrokenArmourEffect",
["warcry effect"] = { "BuffEffect", keywordFlags = KeywordFlag.Warcry },
["aspect of the avian buff effect"] = { "BuffEffect", tag = { type = "SkillName", skillName = "Aspect of the Avian" } },
Expand Down Expand Up @@ -840,6 +842,7 @@ local modNameList = {
["to inflict cold exposure on hit"] = "ColdExposureChance",
["to apply cold exposure on hit"] = "ColdExposureChance",
["to inflict lightning exposure on hit"] = "LightningExposureChance",
["to inflict lightning exposure"] = "LightningExposureChance",
["to apply lightning exposure on hit"] = "LightningExposureChance",
["to ignore enemy physical damage reduction"] = "ChanceToIgnoreEnemyPhysicalDamageReduction",
["weapon swap speed"] = "WeaponSwapSpeed",
Expand Down Expand Up @@ -1070,6 +1073,7 @@ local modFlagList = {
["of mark skills"] = { tag = { type = "SkillType", skillType = SkillType.Mark } },
["of your mark skills"] = { tag = { type = "SkillType", skillType = SkillType.Mark } },
["with skills that cost life"] = { tag = { type = "StatThreshold", stat = "LifeCost", threshold = 1 } },
["with command skills"] = { tag = { type = "Condition", var = "CommandableSkill" } },
["for command skills"] = { tag = { type = "Condition", var = "CommandableSkill" } },
["minion"] = { addToMinion = true },
["zombie"] = { addToMinion = true, addToMinionTag = { type = "SkillName", skillName = "Raise Zombie", includeTransfigured = true } },
Expand Down Expand Up @@ -1136,7 +1140,7 @@ local preFlagList = {
["^poisons you inflict with critical hits have "] = { keywordFlags = bor(KeywordFlag.Poison, KeywordFlag.MatchAll), tag = { type = "Condition", var = "CriticalStrike" } },
-- Add to minion
["^minions "] = { addToMinion = true },
["^minions [hd][ae][va][el] "] = { addToMinion = true },
["^minions [thd][ae][kva][el] "] = { addToMinion = true },
["^while a unique enemy is in your presence, minions [hd][ae][va][el] "] = { addToMinion = true, playerTag = { type = "ActorCondition", actor = "enemy", var = "RareOrUnique" } },
["^while a pinnacle atlas boss is in your presence, minions [hd][ae][va][el] "] = { addToMinion = true, playerTag = { type = "ActorCondition", actor = "enemy", var = "PinnacleBoss" } },
["^minions leech "] = { addToMinion = true },
Expand Down Expand Up @@ -3378,6 +3382,11 @@ local specialModList = {
mod("PhysicalDamageGainAsCold", "BASE", num, { type = "Multiplier", var = "SpiritCharge" }),
mod("PhysicalDamageGainAsFire", "BASE", num, { type = "Multiplier", var = "SpiritCharge" }),
} end,
["gain (%d+)%% of damage as extra damage of all elements"] = function(num) return {
mod("DamageGainAsLightning", "BASE", num),
mod("DamageGainAsCold", "BASE", num),
mod("DamageGainAsFire", "BASE", num),
} end,
["gain (%d+)%% of weapon physical damage as extra damage of an? r?a?n?d?o?m? ?element"] = function(num) return { mod("PhysicalDamageGainAsRandom", "BASE", num, nil, ModFlag.Weapon) } end,
["gain (%d+)%% of physical damage as extra damage of a random element"] = function(num) return { mod("PhysicalDamageGainAsRandom", "BASE", num ) } end,
["(%d+)%% chance for hits to deal (%d+)%% of physical damage as extra damage of a random element"] = function(num, _, physPercent) return { mod("PhysicalDamageGainAsRandom", "BASE", (num*physPercent/100) ) } end,
Expand Down