Skip to content

Handle multiple PRs and contributors in changelog generation + Simplify CR handling#1396

Merged
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
Musholic:changelog_cr_fix
Sep 16, 2025
Merged

Handle multiple PRs and contributors in changelog generation + Simplify CR handling#1396
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
Musholic:changelog_cr_fix

Conversation

@Musholic
Copy link
Copy Markdown
Contributor

@Musholic Musholic commented Sep 15, 2025

Description of the problem being solved:

This simplifies the handling of the \r character by removing them all at the beginning and adding them back at the end (so that we don't have to care about them in the rest of the process).

It also adds the support of multiple PRs and contributors (when generating a release with a provided releaseNoteUrl).

For example, with this in the draft release:

* Handle multiple PRs and contributors in changelog generation + Simplify CR handling by (@Musholic, @LocalIdentity) in (https://github.com/Musholic/PathOfBuilding-PoE2/pull/12, https://github.com/Musholic/PathOfBuilding-PoE2/pull/11)
* Handle multiple PRs and contributors in changelog generation + Simplify CR handling by @Musholic, @LocalIdentity in https://github.com/Musholic/PathOfBuilding-PoE2/pull/12, https://github.com/Musholic/PathOfBuilding-PoE2/pull/11
* Handle multiple PRs and contributors in changelog generation + Simplify CR handling by @Musholic in https://github.com/Musholic/PathOfBuilding-PoE2/pull/12

It produces this commit: Musholic@2d62e1e

For the beta release it produces this commit: Musholic@a77187e

  • Should it handle short #PR in draft changelog? like in:
* Handle multiple PRs and contributors in changelog generation + Simplify CR handling by (@Musholic, @LocalIdentity) in (#12, #11)

@Musholic Musholic marked this pull request as ready for review September 16, 2025 08:40
@Musholic Musholic marked this pull request as draft September 16, 2025 09:37
@Musholic
Copy link
Copy Markdown
Contributor Author

Musholic commented Sep 16, 2025

I've added the logic to prevent the generation of empty changelogs for beta version, it now correctly produces an empty commit (Musholic@b312647, workflow: https://github.com/Musholic/PathOfBuilding-PoE2/actions/runs/17761574913/job/50475345619)

I checked that it did not break normal release changelog generation (Musholic@16fc7f9)

I also checked it did not break normal beta release changelog generation (Musholic@6c06720)

@Musholic Musholic marked this pull request as ready for review September 16, 2025 11:17
@LocalIdentity LocalIdentity added the technical Hidden from release notes label Sep 16, 2025
@LocalIdentity LocalIdentity merged commit 32d7a82 into PathOfBuildingCommunity:dev Sep 16, 2025
3 checks passed
@Wires77 Wires77 added the pob1 Should also be merged into PoB1 Repo label Oct 25, 2025
Wires77 added a commit to Wires77/PathOfBuilding that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pob1 Should also be merged into PoB1 Repo technical Hidden from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants