Handle multiple PRs and contributors in changelog generation + Simplify CR handling#1396
Merged
LocalIdentity merged 3 commits intoSep 16, 2025
Merged
Conversation
afdfd2b to
55f897e
Compare
Contributor
Author
|
I've added the logic to prevent the generation of empty changelogs for beta version, it now correctly produces an empty commit (Musholic@b312647, workflow: https://github.com/Musholic/PathOfBuilding-PoE2/actions/runs/17761574913/job/50475345619) I checked that it did not break normal release changelog generation (Musholic@16fc7f9) I also checked it did not break normal beta release changelog generation (Musholic@6c06720) |
LocalIdentity
approved these changes
Sep 16, 2025
Wires77
added a commit
to Wires77/PathOfBuilding
that referenced
this pull request
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This simplifies the handling of the
\rcharacter by removing them all at the beginning and adding them back at the end (so that we don't have to care about them in the rest of the process).It also adds the support of multiple PRs and contributors (when generating a release with a provided releaseNoteUrl).
For example, with this in the draft release:
It produces this commit: Musholic@2d62e1e
For the beta release it produces this commit: Musholic@a77187e