Add custom mods QoL#1402
Conversation
Reset CustomMods column
|
Thank you for the PR, it's a decent idea for newcomers! However, there are way too many mods in ModParser that are incredibly specific and won't be useful in the custom mods box. For example, all of the "Allocates X" mods are in there. In addition, the cached mods are not all of the mods we support, just the ones on items or the tree. Having a list like this may be misleading for that reason. In general I think this box is used by the portion of the community who know what they're looking for already and would find limited use out of this feature. Just FYI, your UI boxes overwrote existing components, so the config set dropdown no longer works in this case. Be careful with copy/paste when doing UI work in other PRs. |
Thank you for your explanation. It wasn't really meant for newcomers. And it would definitely need a search feature before being really useful. I'll see if I can reproduce the issue you were talking about. I can see it not being worth anyone's time if it actually broke something. Maybe I'll try again if I ever get around to fleshing it out further. |
Description of the problem being solved:
Just some QoL for those wanting to use custom mods occasionally, as an alternative to brute-forcing.
Steps taken to verify a working solution:
(I gave up trying to align the button borders with the text)
Link to a build that showcases this PR:
Maxroll
Before screenshot:
After screenshot: