Skip to content

Add custom mods QoL#1402

Closed
ImmotephSimon wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
ImmotephSimon:Add-custom-mods-qol
Closed

Add custom mods QoL#1402
ImmotephSimon wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
ImmotephSimon:Add-custom-mods-qol

Conversation

@ImmotephSimon
Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Just some QoL for those wanting to use custom mods occasionally, as an alternative to brute-forcing.

Steps taken to verify a working solution:

  • Don't affect much other code.
  • Confirm that "Manage.." control is still working.
  • Confirm that it generates the appropriate text (for the most part, see last screenshot)

(I gave up trying to align the button borders with the text)

Link to a build that showcases this PR:

Maxroll

Before screenshot:

image

After screenshot:

image

image


image


image

Reset CustomMods column
@Wires77
Copy link
Copy Markdown
Member

Wires77 commented Sep 16, 2025

Thank you for the PR, it's a decent idea for newcomers! However, there are way too many mods in ModParser that are incredibly specific and won't be useful in the custom mods box. For example, all of the "Allocates X" mods are in there. In addition, the cached mods are not all of the mods we support, just the ones on items or the tree. Having a list like this may be misleading for that reason.

In general I think this box is used by the portion of the community who know what they're looking for already and would find limited use out of this feature.

Just FYI, your UI boxes overwrote existing components, so the config set dropdown no longer works in this case. Be careful with copy/paste when doing UI work in other PRs.

@Wires77 Wires77 closed this Sep 16, 2025
@ImmotephSimon
Copy link
Copy Markdown
Contributor Author

ImmotephSimon commented Sep 17, 2025

Thank you for the PR, it's a decent idea for newcomers! However, there are way too many mods in ModParser that are incredibly specific and won't be useful in the custom mods box. For example, all of the "Allocates X" mods are in there. In addition, the cached mods are not all of the mods we support, just the ones on items or the tree. Having a list like this may be misleading for that reason.

In general I think this box is used by the portion of the community who know what they're looking for already and would find limited use out of this feature.

Just FYI, your UI boxes overwrote existing components, so the config set dropdown no longer works in this case. Be careful with copy/paste when doing UI work in other PRs.

Thank you for your explanation. It wasn't really meant for newcomers. And it would definitely need a search feature before being really useful.
I think your comments reflects the idea of a linear scan, which was never the idea. Rather, when trying to add a slightly less trivial mod in the past, I've struggled here myself. You'll have a vague idea of what it's phrased like but swapped two words around - greatly alleviated by seeing the accepted format.
I can obviously just go and look at the modparser now that I know how the code works - but that will definitely be the exception.

I'll see if I can reproduce the issue you were talking about. I can see it not being worth anyone's time if it actually broke something. Maybe I'll try again if I ever get around to fleshing it out further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants