Skip to content

Allow failure of "Report coverage" step in "run_tests" job#1408

Merged
Wires77 merged 1 commit into
PathOfBuildingCommunity:devfrom
Musholic:no_fail_coverage
Sep 17, 2025
Merged

Allow failure of "Report coverage" step in "run_tests" job#1408
Wires77 merged 1 commit into
PathOfBuildingCommunity:devfrom
Musholic:no_fail_coverage

Conversation

@Musholic
Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Sometimes the run_tests job can fail, and when checking the reason, it's actually the coverage step that failed (could happen if the coveralls.io server is overloaded but I also saw other 50X http errors). As the coverage is not something we usually care much, it makes sense to ignore errors.

Steps taken to verify a working solution:

  • Tested on my LE fork + should not fail on this commit

@Wires77 Wires77 added the technical Hidden from release notes label Sep 17, 2025
@Wires77 Wires77 merged commit 079e98d into PathOfBuildingCommunity:dev Sep 17, 2025
3 checks passed
@Musholic Musholic deleted the no_fail_coverage branch September 17, 2025 19:21
@Wires77 Wires77 added the pob1 Should also be merged into PoB1 Repo label Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pob1 Should also be merged into PoB1 Repo technical Hidden from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants