Fix Prism of Belief + levels not working with some Skill Gems#1435
Merged
Conversation
Prism of Belief wasn't working with some skill gems as it was trying to match the GrantedEffect Id instead of the Gem Id in a few cases If has 2 manual name overrides for Spectres and Companions Prism of Belief also was generating variants for skills that came from the tree or only from item. Technically it should be using the gem list in SkillGemForUniqueStat.dat but after correctly tagging all the gems that come from items, we only need to manually excluded 2 gems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prism of Belief wasn't working with some skill gems as it was trying to match the GrantedEffect Id instead of the Gem Id in a few cases
If has 2 manual name overrides for Spectres and Companions
Prism of Belief also was generating variants for skills that came from the tree or only from item.
Technically it should be using the gem list in SkillGemForUniqueStat.dat but after correctly tagging all the gems that come from items, we only need to manually excluded 2 gems