Add support for Item Requirements on items with Granted Skills and Fix Soul Cores#1462
Merged
Merged
Conversation
…into requirements
Blitz54
changed the title
LocalIdentity
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115
Description of the problem being solved:
Staff, Sceptre, and Wand items that have a granted skill implicit use that skill for the level and attribute requirements. Body armour like Coming Calamity only get their level, and crossbow The Last Lament.
Also fixes soul cores not exporting all of the potential items they can socket into.
Potential Issues
Coming Calamity always has the same level granted skills. PoB2 does not scale them all at the same time, so for now I just have the first skill set the reqs.
Manually setting the LevelReq on items doesn't change it anymore. Maybe not an issue, as now we are forcing the correct Level Requirement. Only Uniques could have a lower Req than the base (and no examples of that yet in game).
After screenshot: