Fix Fanatic Bow, Bolting Quarterstaff missing flat Elemental Damage#1473
Merged
Conversation
We were not exporting the hidden implicit mods for flat added elemental damage We were also not exporting the spear throw line for all spear bases While going through the staves and shields, I realised a lot of the bases were being duplicated so I fixed that too
Wires77
reviewed
Oct 2, 2025
| table.insert(implicitModTypes, modDesc.modTags) | ||
| end | ||
| if mod.Id == "SpearImplicitDisplaySpearThrow1" then | ||
| table.insert(implicitLines, "Grants Skill: Spear Throw") |
Member
There was a problem hiding this comment.
Interesting, so spear throw isn't an ItemInherentSkill like the others?
Contributor
Author
There was a problem hiding this comment.
For some reason, it is not. Maybe because it doesn't have more than 1 level?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not exporting the hidden implicit mods for flat added elemental damage
We were also not exporting the spear throw line for all spear bases
While going through the staves and shields, I realised a lot of the bases were being duplicated so I fixed that too