Add support for Embitter#1475
Merged
Merged
Conversation
Adds the conversion of other damage gains to instead to apply to only Cold damage Tested with the Rune that grants each element and it converts each one individually Decided to not try and convert each mod for the pupose of a neater breakdown as I believe it might cause more issues and be pretty computationally expensive as there are a lot of conversion mods it would have to check and convert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the conversion of other damage gains to instead to apply to only Cold damage
Tested with the Rune that grants each element and it converts each one individually
Decided to not try and convert each mod for the pupose of a neater breakdown as I believe it might cause more issues and be pretty computationally expensive as there are a lot of conversion mods it would have to check and convert