Skip to content

Adding a test that may have issues passing on luajit 2.1 due to pairs() ordering #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Wires77 wants to merge 1 commit into from
Closed

Adding a test that may have issues passing on luajit 2.1 due to pairs() ordering #1486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions spec/System/TestSkills_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,22 @@ describe("TestSkills", function()
assert.are.equals(6, stackedCost) -- 9/(1 + 0.25 + 0.25) = 9/1.5 = 6
end)

it("Test Atalui Bloodletting damage with life cost", function()
-- Mana cost 96 * 1.5 = 144, max lightning damage 70
build.skillsTab:PasteSocketGroup("Ball Lightning 20/0 1\nAtalui's Bloodletting 1/0 1")

build.configTab.input.customMods = "Blood Magic"
build.configTab:BuildModList()
runCallback("OnFrame")

local lifeCost = build.calcsTab.mainOutput.LifeCost
local damage = build.calcsTab.mainOutput.PhysicalSummedMaxBase
-- 14.4% * 2 gain as physical = 70 * .288 = 20.16
assert.are.equals(144, lifeCost)
assert.are.equals(20, damage)
assert.are.equals(20, build.calcsTab.mainOutput.PhysicalStoredHitMax)
end)

it("Test cost efficiency with cost modifiers", function()
-- Test interaction between cost efficiency and cost multipliers
build.skillsTab:PasteSocketGroup("Ball Lightning 1/0 1\n")
Expand Down