Fix incorrect max resist calculation when using Saffell's Frame unique#1535
Merged
Wires77 merged 2 commits intoDec 6, 2025
Merged
Conversation
Wires77
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1505
Description of the problem being solved:
It was adding the max block to the already calculate max res without taking into acound the max res cap. I just added it inside the m_min, so it can't never go over ResistMax
Steps taken to verify a working solution:
Imported the same build that had the problem and verify that the max res can't go over 90
Link to a build that showcases this PR:
Before: https://pobb.in/7VIVf1JBz-d5
After: https://pobb.in/HF0qCGlUL9ry
Before screenshot:
After screenshot: