Add "Armour Contributing to Reduction" row into Armour calc table draw and update row coloring in Armour calc section.#1547
Merged
Conversation
…o that it prints an effective armour value for any damage reduction with a percentOfArmourApplies component, notably for armour applies to elemental and chaos damage. Add prepended color codes to "<Type> Dmg. Reduct" entries in CalcSections. Remove white color from colon in CalcSectionsClass:Draw's Label DrawString so it can inherit the color of the label. Signed-off-by: Andrew Devlin <devlin1991@googlemail.com>
LocalIdentity
approved these changes
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Description of the problem being solved:
When viewing the Armour section of the calcs tab, there was only a "% of armour applies" row and not a "Armour contributing to reduction" as it was in a conditional branch not used by that section's draw. This led to manual calculator usage to see this value.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
n/a simple to test with lines added to config
Before screenshot:
After screenshot: