Skip to content

Add new 0.4 skills #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 13 commits into from
Dec 13, 2025
Merged

Add new 0.4 skills #1554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
df56bf7
Export active strength gems
Dec 13, 2025
250ff76
Export Strength supports
Dec 13, 2025
165bdff
Export Active Dex gems
Dec 13, 2025
39d166c
Export Dex support gems
Dec 13, 2025
fb501b5
Export Active int gem
Dec 13, 2025
0f2044c
FEAT: 0.4 int active/support export
Paliak Dec 13, 2025
bc2b9bc
FEAT: impl simple supports
Paliak Dec 13, 2025
3983729
Ascendancy + item skill export
Dec 13, 2025
083ca83
Merge remote-tracking branch 'Paliak/0.4_export' into 0.4_skills
Dec 13, 2025
0e05631
Export list
Dec 13, 2025
fd72c70
Regen modcache
Dec 13, 2025
cd33893
Fix Test
Dec 13, 2025
66a8427
Fix JIT 2.1 Modcache issue
Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/System/TestAttacks_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ describe("TestAttacks", function()
runCallback("OnFrame")
-- Add 2 skills with 1 red, 1 blue, 1 green support each
-- Test against Quarterstaff Strike (skill slot 1)
build.skillsTab:PasteSocketGroup("Quarterstaff Strike 1/0 1\nArmour Break I 1/0 1\nShock 1/0 1\nBiting Frost 1/0 1")
build.skillsTab:PasteSocketGroup("Quarterstaff Strike 1/0 1\nArmour Break I 1/0 1\nShock 1/0 1\nBiting Frost I 1/0 1")
runCallback("OnFrame")
build.skillsTab:PasteSocketGroup("Falling Thunder 1/0 1\nIgnite I 1/0 1\nDaze 1/0 1\nShock Conduction 1/0 1")
build.skillsTab:PasteSocketGroup("Falling Thunder 1/0 1\nIgnite I 1/0 1\nDaze 1/0 1\nShock Conduction I 1/0 1")
runCallback("OnFrame")

build.configTab:BuildModList()
Expand Down
4 changes: 2 additions & 2 deletions src/Classes/GemSelectControl.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ end
function GemSelectClass:AddGrantedEffectInfo(gemInstance, grantedEffect, addReq)
local displayInstance = gemInstance.displayEffect or gemInstance
local grantedEffectLevel = grantedEffect.levels[displayInstance.level] or { }
if gemInstance.gemData.Tier and not grantedEffect.isLineage and not grantedEffect.hidden then
if gemInstance.gemData.Tier and gemInstance.gemData.Tier > 0 and not grantedEffect.isLineage and not grantedEffect.hidden then
self.tooltip:AddLine(16, string.format("^x7F7F7FTier: ^7%d", gemInstance.gemData.Tier))
end
if addReq and not grantedEffect.support then
Expand Down Expand Up @@ -709,7 +709,7 @@ function GemSelectClass:AddGrantedEffectInfo(gemInstance, grantedEffect, addReq)
end
function GemSelectClass:AddStatSetInfo(gemInstance, grantedEffect, statSet, noLabel, index)
local displayInstance = gemInstance.displayEffect or gemInstance
local statSetLevel = statSet.levels[displayInstance.level] or { }
local statSetLevel = statSet.levels[displayInstance.level] or statSet.levels[1] or { }
if not (index == 1 and statSet.label == grantedEffect.name) and statSet.label ~= "" and not noLabel then
self.tooltip:AddSeparator(10)
self.tooltip:AddLine(20, colorCodes.GEM .. statSet.label)
Expand Down
Loading
Loading