Trader tool: OAuth support, match mods by tradeHash (fixes many local and essence mods), add price sorting, add radius jewels, notice when rate limited#1801
Open
vaisest wants to merge 47 commits into
Conversation
This was referenced Apr 19, 2026
9811d7c to
0d2a6a9
Compare
vaisest
commented
Apr 21, 2026
| @@ -553,7 +553,10 @@ Highest Weight - Displays the order retrieved from trade]] | |||
| main:ClosePopup() | |||
| -- there's a case where if you have a socket(s) allocated, open TradeQuery, close it, dealloc, then open TradeQuery again | |||
Contributor
Author
There was a problem hiding this comment.
I don't know what this is exactly referring to, but its fix causes another crash
Member
88aca9f to
ddb73c8
Compare
vaisest
commented
Apr 25, 2026
Contributor
Author
|
Back to draft for now as the changes from the comparison PR need to be fixed here |
…currency rates
…ate limiting waits if possible
…lems, and to show it on non-429 rate limit. (429 issue solved on GGG's side)
…earch tries to add results to controls
…shes in a similar format as previous mod export changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #1409, #1314, #748, #993, #1667, #185, #1748
#469 might be related
Description of the problem being solved:
Most of these changes could probably be ported to pob1 for consistency.
Steps taken to verify a working solution:
Possible issues
I had problems with 429 rate limiting. I'm not sure if that's because of me mashing f5 to test changes, or a real issue.Issue was caused by Cloudflare, fixed by GGG.
Radius jewels don't generate a weight for the mod that increases the radius. I'm not sure how this should be generated as its value depends purely on the other mods on the jewel. This only affects the weighted sum, though. I'm not sure if it's worth paying attention to. For my build, it's sort of useless, but if it has a large impact, we could assign a manual weight to it to not exclude it from the weighted sum. In the sorting done in PoB, it is taken into account.
Some modifiers don't seem to get tested. I don't think this is a trader issue, but rather that GGG hasn't assigned spawn weights to some mods. For example, the jewel resistance corruptions only have a default tag. This seems to have been a problem in the past too as seen in #1269.
Link to a build that showcases this PR:
Nothing specific, but:
Before screenshot:
(not sure why the previous version doesn't work at all)

body:

amulet:

After screenshot:
body:

amulet:

In search results it should also be clear that more mods are generated. For example a lot essence mods and local-only mods were previously missing which made results very bad.
Depends on #1830