Add support for many "All Damage can Contribute" mods#1845
Open
Peechey wants to merge 3 commits into
Open
Conversation
add support for all damage with this weapon can contribute to chill/ignite.. refactor modparser to match all combos of ailments
… me get to configOptions to set correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Primarily supporting "All Damage from Hits against Bleeding targets Contributes to Chill Magnitude" and "All Damage from Hits with this Weapon Contributes to Chill Magnitude" but I've made the parser rather modular so this should hopefully cover all combinations possible given the wording matches. There are some redundant flags being set/pseudo-set like CanChill will technically apply ColdCanChill but it allows regex in parser instead of manually configuring the combos.
Known affected Uniques:
With Tidebreaker, any damage should have chill breakdown in Calcs
With Icefang, any damage with Poisoned config should have chill breakdown in Calcs
With Veno, any damage with Bleeding config should have chill breakdown in Calcs
Added a really basic test for Tidebreaker... I wanted to get Veno and Icefang in there too but something's off about setting those configOptions in a test.
Update
Added parsing for The Three Dragons

Build:
After screenshot: