Add support for Commanding Rage and Expendable Army passive nodes#1846
Open
Peechey wants to merge 4 commits into
Open
Add support for Commanding Rage and Expendable Army passive nodes#1846Peechey wants to merge 4 commits into
Peechey wants to merge 4 commits into
Conversation
add support for rage effect also granting you minion mods
remove duration from ManifestWeapon add BaseFlag as a modType to avoid some hacky solution in CalcOffence and allow cleaner CalcSectionBreakdown
|
Probably supersedes #1810 |
…ober chaber and trenchtimbre add test to maintain both scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adding support for these passive nodes:
The only temporary I could really figure were Unearth and Raise Zombie as they 1) have the phrase "short-lived" in the text and 2) cost mana/aren't spirit reservation
Adding a test to make sure the Rage scaling for minion mods is maintained.
Update
Converting baseFlag permanentMinion to duration. Adding a modType BaseFlag so we can have mods specific to skill baseFlag, mostly so I can apply the ActiveMinionLimit only to those skills from the start and not have to hack something in CalcOffence when we are summing the limit. There might already be a way to do this, as always give me a shout if so.
Update 2
Updated to work with Chober Chaber and Trenchtimbre -like mods.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
After screenshot: