Skip to content

Add support for Commanding Rage and Expendable Army passive nodes#1846

Open
Peechey wants to merge 4 commits into
PathOfBuildingCommunity:devfrom
Peechey:feature/temp-minion-limit-and-rage-effect-minion-mod
Open

Add support for Commanding Rage and Expendable Army passive nodes#1846
Peechey wants to merge 4 commits into
PathOfBuildingCommunity:devfrom
Peechey:feature/temp-minion-limit-and-rage-effect-minion-mod

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented May 12, 2026

Description of the problem being solved:

Adding support for these passive nodes:

  • "Every Rage also grants you 1% increased Minion Damage"
  • "Every Rage also grants you 1% increased Minion Attack Speed"
    • Commanding Rage
  • "Temporary Minion Skills have +2 to Limit of Minions summoned"
    • Expendable Army
    • Known by All (Druid)

The only temporary I could really figure were Unearth and Raise Zombie as they 1) have the phrase "short-lived" in the text and 2) cost mana/aren't spirit reservation

Adding a test to make sure the Rage scaling for minion mods is maintained.

Update

Converting baseFlag permanentMinion to duration. Adding a modType BaseFlag so we can have mods specific to skill baseFlag, mostly so I can apply the ActiveMinionLimit only to those skills from the start and not have to hack something in CalcOffence when we are summing the limit. There might already be a way to do this, as always give me a shout if so.

Update 2

Updated to work with Chober Chaber and Trenchtimbre -like mods.

Steps taken to verify a working solution:

  • Verify Active Minion Limit increased for both Raise Zombie and Unearth
  • Verify minions have increased attack speed and damage when you, the parent specifically, have rage.

Link to a build that showcases this PR:

eNrVXFlz4zYSfo5_BUtV-xTF5k3JZW9Kvj1ljxXJntnkZQomIYkxSGpIULaS2v--jYOHDsqEnKpN5mGGBPtrNLobjUYDmpOf3yKiLXCahUl82jEO9Y6GYz8Jwnh62nl6vPqp1_n53wcnQ0RnD5OzPCTsi_nvgx9O-ItG8AKT044NuEWIX--TAJ92bu-HD6PHjhahMB4n_gum12mSz4F_R_MJyrLPKAKyEYqnOO1oKPNxHJxXHz4nMQbKGUqRT3F6x_oY5DQR3Gmaw1eK0immXwrJ9W9GB6T64WRI0BKnY4qolsFfp52BT8MFvg9joLsLo5CCpIjkwMg0O0cNGNAImuKbGrFhOYeWbfd7lm7pTv8d5FmeZvQCRfCoymE8xzioQIe6Y7qW4Xi9vu3ZTaBhii8nE8yHep6G9HyGYr_WtdMEVCa-zwkN5yRkhiv02ER_s8lb15uIHxOKyMVwXNHa5qHt9mzdMvq63t-NSypLNfbwNaSzMwLa3aMXhr2dxiHFe4KHSZgl8QfGV4c2DvE8JwQmaCvaEc5wukA0XBWrmXcSPYfxXtobpBg9TISHjlAQ5tk9pinOSj5uE_Iexeg8ySrrejtJhziFWEJXEPo7gDH2Ewg_dUhPb9HJdmgj8i6c4PaUSgORAFVp9hvH5bgtnTLj_QQaQZBtRzlOctKSklbhzeh7zVPo-wqlazVRXuC3FgH2Nq45-o5O63SwNDR3ukjY9H5_vI9p-JxT3IKQRaPLm2Elpm7Cqub2bVd3dLtxcg5nyyz0EblHb2GUR7AyPKIXXEnWd9xmV53OaAxRrQnrWo0auApTvAfsPCHBPrAZSrI9RniB0pcYZ1nbmA0xuDWCTfQ2MkDa4R8z4tvYL-mdXVyf4lRK086KEzyCWc3yo2eC20KqTmRwaJNKiL6mOJYdLtup6Q5jf3YNOesItZkKbCmociDD3qlZRlzX7E6uWzS7g_8qQkFNDLhdTb3DnausoqLG8zANW0kkKLcM32sNWR9_M_Iyxul0OZ6FmAQtVqcadaGvczRvM3owfx3dyg1Wu1Ny5TpU0VKj-n7F2kmmKtQCZfWVyNutLkHdTlMLFOC1bUazy2PI_5UQwzT5ne2riBoMhkGIOmLP3i7whDBYwuwMK2VrRNsOBmmU5GlLZxfErYxXpAViqzzCQe63S1jK3e4ZSfyXtsMoUVzZStABpch_uUiCqZpFlRCr8o3z-RzCGpsJbRmwfAdyhLCW4_7ktKB-gFncKpqxzKh9BxV16w7KbK99L2uQ9mNh6dpaN22IW3dQmvMeomQEqxKv7dwntfJOY6CqI77OICA8ZTDC8UtISNXxobWjIJRhcJmtu-3GVOIqJ6RVLYATtqxJDJNX0NeM1esyNWpIpavVqFGUFMd_LFvzXyFv1cFlHOQpm36t-1hHtOqmRZ1SfNysNq4VGk3TOux7jmWYtm2U6fUGeL3QaJoukOt927L6fy1oo7Rnevah23M93epbnuftxm0p7W1Qbi3ttexle2lPAbxZ2lMc37ZptEG8o7S3QftOaW-T95bSXssxrOwve56xi253zrgVsjuB3YDszOl3UivK1j7JPssnk0zzQcOI3sHqcdrpaM_QJp5Fxu3naYblR4F6DCNIVbPsAlGkBbKO8wWlIYqpwQ9S1hpN3pjx05arkFCcXgA_FoSYKFqGUerPWBdXiJBnSGWYHFWr7PjkiB_rsKdbiqNMyzMsanFfMZqDBjBQThDJQOhslrwyjVyEsMylbLHJisMZxGMZ48AB8miGvWthULz_MALJ6fJYGw1GlwdFJqiZN9o98vHBFWw0aehr1ylGdIaiCKcH5ymaUBwca6ybA1jjJuHbsfZnyg6SjvVD5793CbCAzBMwGewFV7JLuTN09sQN4mDgg6GQvxRJdjOjQRCsM3l8TW5QHLgHYzD9zs5FosnjrNVIzU5iGPMxTcMXmV5upb4myTMifNvDc4drHPHjNCmPsKp98EuOCLeFqR_w7yP8_Vjzege30ZyEfkizY804-JOiaXaMuID_FV1n4IdgtPGcoGymibEeGJ75Ly0sBqSVppWfQT2ZZtoaTTTb2Pj6o2EY7FOhbE1o--BH89D-F_tQjF27Cakmhn5grHQoVKhxHR786DIQH5SWTDTwfo2rQ-P6yJgjnkBKxg8juXeaHY3rj-VXsgC2RmG9S2G_S-G8S-G-S-FtUpwcsVlWTjeYfnLG7ZjJgvOYJFSLxcEs6FuDQcKSGA2fn0Z3LFawl9ugjGsA4LHmNoDvEvcJv4KSTdeAVGAVHCcBZmDx7Wijxzs81cx3O1ylNxTo-YhUAEJJmqmNX1mm3xoHe1-lfs4woYrsVfTEElA1gSBgLFiOq9iFpYC4gljxojSMG0wiTJWFMvd1Ya_v6g0ezD81-4u6ixmqLlbgGiDGNreJcqKkP2EiJUdOgqVWlIkUUAnNVOfxO0oWIRDim0ikUhRA4GN5zlfMCgWZyHN4esOezhHxMxEw43ledJSxxeFbnEfP7KKD-Lc6D6lTRmHmf2MJHbudAlkRLIvs7szl1dXl-ePtl8stEJY5iYwSUsEkIRjFRSwWxGNRzIOskRA0hyWtSrry50x8PO18CfErX8QuMEUhYXoEQt4yxqy6p8SN42BJLTaTjFf1qsLp8g2nbMn-CkpPQyzlKt-UhRIisMScZcWCG9sVqjASKcE5yqhI0rmm-F5WhQtLPeRw2KMSFjIpRGTP8llZE3Q5x9kc--Ek9FnqXTf5I3wTbUp6kVlWaW9ZaVThwTfegoF4VAGLzbNAy2clrfKNu9SqeFaBX2AfybGLRxVwue9LYn5TjHEp25Q4fYZ9OnNymDSDkLC6n7TsJcFlgwrDBzrDqSg_Sk73EKaKBsWJI-4GSD61dyVd8TIB1xB7UoGKc1Y-BvakNGnkyaOY7aHqlF2tJnB71FtUWInKsdShrDkrmaFYWYPyWWkkxfEbH4R8UZooPAYPFkkYiJMIPmXWGtWCBuReH2fDj1f-AjblAdrHefHcSVpaPjfCRbmkjn6iIduJf4wJm2Mf48Cm2sc48BS8JXrbhCmTkNHO_GN7x9MiXBUvCviyer83B3HGsDecH4G0RDfFfnBoXpGrgn_ZohRAaR5fgDaqmdGO1eaguFRr8eNjvMS6-BcNVFbpxI2tKgKIBmVGsI7flJnivpzK08MbjAg7ZUjIxxhu3ExrzWzTBKxSns9RHBTcHlbT8321B9tBYMqL0BesIp99SEpYrqPlLj4nR8X27-Q8iSfhVJauxUu9eF22FPU0GlKC-cqBckJlEW1lY1jelBexrNxElhvbOjVmot5mZwm71FdsIvmbJB4S5ONZQgKclkUOttNj-5qs4m4001cCsWkdY3aPCWYQWbZCcwHLo_Zil1gCTesdaP2XBmv76UaMPG0syD1dbwaM_QT2-HupozjBoNfwFwowuxcRKPLg29vlU7aPVuuXKgqMtWOoWTgNycOErxMwYL7YtegrwFESXyVptKEkvYXt1i1uvQeSd3pgfvKKdd2M7yDLbLXsy_ZaSMgOBb5ixC_Grg_R1FvYQMmpa6YP2XqEA97neZLHdIzJpMbmPTcvTuoUxN24JtPGLFs8fhBFSXt3510zcvXpv3ocpoIstj4FwjZ6O6LADLYVCkFA2L5-EagAvWsBdqJUk0pvoTYVY1WSravMLn5nc1QuSmIp42_s8THFmFUHtT-SRJz38UnOX_9z2un1-4e2bVqurjt9a-dJrjghHtOUFVoZ_NfTTt8wDvs907V10_J0cZno5DaaJynV8Bv7Z4hSuqyXNLlEcm1ldwTLZZW91H8AKOq4GmUDqH7bZzNB2NkVSpeDVeI4JKI4DyIbhuuZXauvW17X0W2n3-05br_r9Cyz3zXtnul0Lb3vQYvbt5yu3XMcIO95utc1DPjetWzDcrt93YWPtmdZXcO1Xb1re4bnsWfD6tqu5fS6pmX1TGADnXTZiUDXMvqO3vWAn215ttvlB11dx_MMvQs69lxg2GPC9QybMXHNXheeoAfHA06WZ1pd12AY03BckATmRQ_wOjDse5YNoumsX90wnK5j9Eyja5sudOy4rmPA4FwbJAT5DRg_69T2bFPvmn3b68sfXUrVRiijOF3KWhAzq1A_BKDlbQyfYkQYaYGqNZkyy3ka3fGHH2aUzrPjo6PX19fDOaKzZILfQoIP_SQ6mgMYrP0Tr6T_xAx6NIA_Z9PB4G5p_hrd6DOMh7_9OiTOoO_ECxT-5365eJ19mf6OkNv_5XJpj58GAR399vyFpvTmbdb7Y3r3-j3_FH15uMqdb-eL8afHbzT85Sp6NKOLZLG4uBoN8PTXr6Ps0_Xsl_nDS29O598fg7F5dvP5-uH5Jn3p-UsfpDg95QM5KkYiT4IyORtZMpuG4FNimCdl0av4wDK0z5tOx9Wt7G-briZMLpxMGpX7l_At4Ul13xJexf1JuJZwJe4-0sGE-3Dfku7DHZlPEOE9wpuF9wj3494GiXNM5VjZrZO34lnq6mhFWSdHbEbzcMSmPHvgwUBD8zk4WZn0Q5x-HQQLtuo9wsYmKz8AHxrGSFa9CBHhQ5zVFwFEnHBQeeMlpdc4ys6WF8NxGbXqjVesWLd2x4lHvHw-F3SsdA4SDO7uWP88n4dWeSeCT5qqVUbTGNKo8tdMMpRJsepXXEQju5pA8gDfxvKCZTla9gvpQTUovhnhw4I89JlUm5o1Ok5C0DOTpCN9FGSTKHHnwyyVwRDiuOm08xRDQKezsyRmexzw4tynKyRShAY6WCRghLcxuIEMvTXo7iHUsZKIM6jLbGyRuRrwQtx0YpFIitcpfn9u6hJT-yhuWHa0qTgdvMcUBYgicfJ3BOo6Km7ElNzYyiuWp7Lpe80LfJbb1dIJweDvaegRCmEv8htzerzNwGvf_y6G5WIVUm0zbo3gXQNnpYVX2FZW5s1a0f5PMvWmvT5ilZoB7jCajwmKtmu_-Kqg-ophpXfWponGHUr_v4yf1WrkyvD4mpRaMGpKkJ8ZpdADJ9ylinKlGYmrgKs-OMXa7e0_N9KMc9hDsmoSr3sWR26bEaeB7u8TeSqxsqbYUyNpv7yscV4xPbvPUn75Z6814xdMME3irwjSwSTNmledLZR_Fy8QoiEiRdvuB8KT10gzhZi4BpU3MsVveyr3KKi0Uph2DiIfi7KAyJ3Z4-eEiiydNcuXk6ON_9vnfwhJNw4=

After screenshot:

image image
image image

add support for rage effect also granting you minion mods
@Peechey Peechey added the enhancement New feature, calculation, or mod label May 12, 2026
remove duration from ManifestWeapon
add BaseFlag as a modType to avoid some hacky solution in CalcOffence and allow cleaner CalcSectionBreakdown
@krryan
Copy link
Copy Markdown

krryan commented May 13, 2026

Probably supersedes #1810

Peechey and others added 2 commits May 13, 2026 12:47
@LocalIdentity LocalIdentity added the pob1 Should also be merged into PoB1 Repo label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod pob1 Should also be merged into PoB1 Repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants