Skip to content

Fix scaling for Inexorable Critical II#1852

Open
Peechey wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
Peechey:fix/inexorable-critical-support
Open

Fix scaling for Inexorable Critical II#1852
Peechey wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
Peechey:fix/inexorable-critical-support

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented May 13, 2026

Fixes #1851

Description of the problem being solved:

Inexorable Critical II had CritChance for the CritMulti scaling mod and it was using limitTotal instead of limitNegTotal so it was running m_min instead of m_max, applying 50% less always.

The configOptions for seconds since crit was also not showing as we need to match the tiers now. I have another PR where I introduce GemFamily which could be used here but it's only two skills so using SkillName and a list isn't bad either.

Steps taken to verify a working solution:

  • Validate Inexorable Critical II scales CritChance and CritMulti correctly
  • Validate Inexorable config shows and scales both supports correctly
  • Validate limits for each mod

Link to a build that showcases this PR:

eNrtPWtT48ayn-NfoXLVuZVUDOj94LI5ZYwB78LC2rAk-UIJeYy1yJJXkgEnxX-_3TOSLMmSJQP2Sc5NUrVlpH5Nd09PT2seB_9-njjcI_ED23M_NIVdvskR1_KGtnv_oXl9dbyjN__9S-Pg0gzHF6PDme3gG_GXxg8H9A_OIY_E-dA0lCZnjU3ftELin-Gz9iz0zr0h-dAcmU5Amlxo-vck_Bqz4m8FQHHMIPhsTgCqb7r3xG9yZmARd9hZvEDWI9sd4suJabsDz3og4YnvzaYgcJN7tMkTY9Q7v7zoXzVBuB8OLh1zTvxBaIbco-nM4K1gqPKuIBmqqja5AF58aLah4eY9ObXD5t7aWIczPwiPzAn8LMfelSV18X9MYTAlZFiKpAi7ghiDXvqkOxoRK7QfSce3w87YdC1SD7cGvLArKWnw85kT2lPHBmWXovB8jHFaSV_URWFXFHTNEA1d0GPEKy80naPLQSken4X0wnU53Njh-NABNa_isgK3d-_aIXkl8qVnB567VvtqAXdmjgPdrxZsnwTEfzRDe7UgJa3oeJM7212tPYFXdnVdlBTRkIUF6rnpmh0vCKtFRMhL4kN_D1ciCIq4y-uKogqyoUlSDn1ALA8Cxroc18Q8s0ekPmSdVuUR1pXmde3oDurCrU34dQL1IX7Wgxx4M2clpJZAhuXhS9YXPeT7KkBBFmLII_K8wjm1FMGVkEYSantuWJPgKkh-Id-jhx29Rrjx7btZuGI8UA1B2pU1RTBkTdUyUap7elkeRlKjwuV4HtiW6Zybz_ZkNoFB4sp8IOXC6byecuz7cehCjHsN8rHtk9fgdTxnWBdP0qXELWDs84K6iAtjmf6DS4KgbgiHIFyFIfKSlg4N5elBKgOx9hG051q1yV67fiRRbZQ-RAJMl-4cUiehyHKJAkq9cNgn98SN2M3roZwRYo1PIKXsm6u6hMRr6fGjRqBC5SLoKuXmydZQbkpRWYwqRQkGv5sZn9dUFqLUU5YkpVzM9lcm1jnIGgpQ9F2R1w1FEUVJ14Uy_Cp1qEkK0XWJfz8fjG3iDNcEj7XXMac1PSKNvcoz-GJ2a1ksjVrPcpkBuR43QVSEZE7TfTSDVUOQpElZbTD4VYpYDIQAPCRVU59FdyKQ-K-Hcul733CS5ayJB01xnFegrMdPkBRB2xX1xXg_chDbQ5PCYFnuukIOpYJR4gRtf-LN_JqOzYBruXScG7B5c58MZ1a9xCWZBB86MP-v24wEiyp9LdR2GJrWw5E3vCd1USiTtTCy8g1m0ynEMOwWFQQ0JZ3zQJ5gr0iL9QLgC-jYqyLXggEmRxUMFH4ZuD6DJOWrzSWHUcVKVjMJWwUbvgC4ioOwKxvykk3PIXpOYByi1Z5zb8W4votpk8EnKslg3owhSlwH0NzBg-045c3cVVNFo4CA__TNoT0LzkkIf1c3-Hjm1KvJUMCaJYtL7wl0N8baX7kIUhE0JNY1RPGJ-8e8Nv0MeC0GXXc487Ev1uaRx1iwOZyNRgFneZM7MzwDt_rQbHJ38Iz9ZuBczx3NMAK0uI5jQlozhx8Ug2PCNzlr5gckwoFpNkbQR4CLmFzZExj-guDIDE1uGE0MvwIl0w0FWjDNPRTpw4BWVY9tJyT-EdDGBjA1ENO3xrG4i7-OTce5gwgJT5HxwR6tB-Mv6qYBsBmZMyc8IZMvM9MBASk5k4U7BBmQkKnN8xEqOJyDR31ohv6M5B4eYxqTLUpxwdh7woDJ4K7mUxJA0D47a6YYn7HitOv5k2Q6ysrDsQCcPaQyhHboLIrQCBLB0JJzeyF0x3SsgGrMMe-QeJOzXcuZDWEmFXWgpOJNXJz3DOMm5SghEcrohwMQFdyIWqM3xMHXanKuOcFRwYr-jOrsYuSYIHrPHZJnaJztZB9FEtLnOQkC5BtxYB7c5L6njMPATxzvznSEGCn9UIwfWt7MDaka7skEKUKQMYfgcnu9EKy2h6bbo82EX9iAveKm9s2pPeyYAWYxkTWvnrx06ykEF4FwvV6iCuFdNBExTcvBNEPF2KRyEt8F9ZguuSKTqYdMSzR17t3ZKEuEl1ZR_Gozqompb8NhEp0kTSrRRs8lEPOQD361wIwyKHYfAHz2aP2BiyE35kQFQm3bl5ZFWOFSl7Y79Ww3jEHTeovfcYuXm1BZXoStOtlS-9d2tkpPS2stUUU0PNR2n_-Y70QKOWCR_D88Kl74dxejQQhjeZBWOzzmvBEXv3jfcTLFc4vjZbqlJS55Bimfe59MhIpjHwPiEqj3DXzntgtJZM78eZ_OyZkKh3kaFD2t3BTAUnvfWfWpTpBjtCJ6HjuEhHQSOnHhUcn4c2r6E8-1LS4G29jok5dnG0NPSnEwaQjsqRmSVTmMee-CjFZOZZlcJgJJ9LWhpCYnycZ7dzq3YbyDySo12SObDNs-MYvdKgHhEGZjPpWRZNu5TMKcVVQWflV7PJLWGo-iv2sPSNeu_X1GDkEzOCOOAsah54TZGBwHX_bmfcenUhG24M_RYFWuhRLvHow966Gg59Pnm3FjSnqruVRcmIlL2yVqwHBtj8ICbXSxWu97kyRWbE4xkRDbDIFpvv_PUpzUw4jmUm7zd8qCjog5dOadme9jvXrZjzvezMfaNReBbMaPM1JstaNnOG92vrTu-JSYjwYju2RYSl6-78iUZ77F6dNSu19tlavxDNcdBzgV24SFsvQX1sk-f1_DpGlv0SiZJv0zqf2rhnNIO_DDo-m0_Yk5WYT0nBESMC6G29gUZEmibU9DLn17suC-qiBACG6OYJ_pivUWgUSf8jZXCkhLsm19ZZi_YtK22UHxn5Cb_dQ4fDRdC4MtQhXkbwkAq7C-1V9LSt9ZMbY5E8lyLv8CYMEEF7-6T-ySkHhBl7mCxvHL-Tv07NKPBClJtt21M21c9WHJ9xzPvSfDo5lPd6AUqywB42K4DeitTJatDyO48S0IyWrNxeYdxp9g2EK5onLJbEp8a6Mf50qE2er8KtvM9YeSAOafuJIFie8L8v4JcYlvWy2uHYYzF1zvxnSHAOZ4uHeLmFNwwo1-xsK11Ec-QGfLua7JRU_fd-xJ2L3WalFz1ykJLpr4VnstzHUByRc3sMg09EnOXOJmzeXYFsnaij15bzsh1a0aiTbjr_SF99Axg-mYTOZpdacevq_GE8JbTMkWjSmJ_5kFfZkyWvr5-yoiTXuLulheu_gXcUO23DJebZm2QWYZ5nsbYcF0ex9vMk0tc0m6LhXSKLYutTiVixavJlAbm9rmpNl-MSBivPGJ7bpOS_XSJ_czh2a5BcZJv3xn580x36IDU87xmulSF2YrqUtcl73cnMcy-tv21IhtoZ9GP6ExdOU2W7CNPyEmj-z7aJE2-4Ou0mZed5A8ocumhWTZ9BFbcR2tm-6501nIubPJHfFx0yJTNuiD7goPBuD7JLvWLJaQYd55nkNMN243Q0ZUG32r68LwSb8fxhsF6-Gde4_JTim6ft8iY88ZEj-RVEkkJcijcF9KLcz8lpliJCHGCex727kY0b0Pg9BMNhkUo4k5XtHUCHJhukd4gLuW1iEQL_ZfhWKoSgYnu4urViMnycEiR_ZoRPBr2Qn8Yw4JbkoarknjxoQ54fwapqZ9gls9nfmaBAYw-XPrYUvLCl-j3Wy1Q6VREvjOGDtmJXzeIomzvs0k7cnEq7RHnjciVLOVdDWrR9xeVUNapcD6djgGcYdUTR0MiwPijNbooPlNcyUSF2v4krj1sTAUrIWAolUg6LyaxUlv1izRoqBlbZbZrVuMwy-bq1pnGp9FS510VGKZpc6V3vpY1bksz7fGNXpXItSQTDz3GEvdlUhaLk6yHaue49BNQisNJGY9B5OKdToUOk3mYKm9ZOCl4zX7C3_SkT8arvF3sqUKN0dBuhJ3bAs3R7FhcRYQNhCz6gnFYLknZYVU6OiustG8T7OIfa7f7ncbUTWm0Z6QEIaAkOtDf2h0fHMUkuE-hwwalz4Z2c_73J8-qmmf3-VF_SWpJOKxC9oyjKYbCxgsHxkJzGfPJY3BbJRGEF4WPVjNv-R3DVl-yY3eCyhKj5qkT77vcyLf6E0gqlh2GOxzQuNPGICDfQu9veVTVPTGl4Txzz9qO4L007-40ONon-D6CVTjZ13B5xO204zDxjZ-FkQ-_RBb1_hZUigFbEaGQPR88XU79RLd59wbUveLEzAqFv6K3CvzXkze87tKIYRUCSFXQijLEAc0Jc36k7bCn45tl3CHxAkbmM9PuIHjoTWkStfitaxr6cswiiFmXUtb6VrgPYLyssjgCtxLkIWXVDhUylxLFdOuJTaOHTN4CLh7mNJxQEWjB-ZBtsdNIRawPtlI_OzUDLgfhR3pJy6lEnAmnl_2sKzXZRwMG5JxMJEvdt0VzlVmeLHC_TbkXDkItZ77CfKqeJb6FlAnnLGN_jRCX7gsjhYFNVl9yeVlDCbGUSs8UTL0FzYJXKyJQc4406NuxsjIy5i8pLwk57wQ9t0r56fRplwaAdmRiuCkA_y_0QdlRFDFPxc-buTDZ-y_Jz7d7ECnlvscRUB_FvmfuMXHjoYB3mjHnZOjjeOYphq6kn61CIjR659lGicpXW_EmYC4gGGE2LS2oWR4UOZptXB4KsrfPLZCkrzs3N2vjY7nB6btQxQww0aU8qHNhConlyXt5cyDGV4SOSNsdt5IdMCOWtA7hNxgL_AFIVlLhW12eI9cPIqvGOaF1UG6MAco8_lKN9cLs4QAk9uXjJ_GJzdwNPHNOXGkQ44pEYK5UhDMZRrMmVYq84Sl8P7K_KE6xG_Zy6uDfA5Cq9lT1OKeAuHogQQPMDIfejjQJp1FFvWqzqLq0kts96_E8cBJ5gVdQ5eVGn1KLuguqpTtU8orkpaVOfEitZFeIqFY_F4cNCSVdJ46_YVvSKs6ibqyk6gFKfVrvB8PwOIW7YnocwSLsYgkAC4MJDn2_119pqhHiIUdYq87aEBKOvMxK_LNaapHCKraYMeLcex8Mch0KzN1lTeKnb_tDtNnlSm3RRmXUDaBLMng3zRy8Opm-oBW6OaQcXIZbRZPItccB_77nb0wuOvFwf3YJ-QOwjpMszrmdOHJKq9U-q0k1wjaSgGisabPQgBfXdSoivAipF5bdNw4Phv_eOsrvdUo8NYj8tz4aA4J157MHBJWT0aFytqaYqRcsW7KoUj5DF1aDqMgLPQpEH797J3581JCknLCbO3kT-JaY3Dql7YDCRbM2IJ4gzgu5MNrB6BVUVpuwgN6ynG6aifwO4LyE3pTInVD4lc5dlEYlvl0cs4Kewt6713V-9sVXqpz8hyEXrOrrKjdpBcGNphlIEdR-KquY0i5wM5wyyO6xuvZQmJBsVGDGPyZmP7dHPzUJkE7LhMV5RnQd_M1Gjlbo6lRsHnPsgwuCMyVS2JXz9UdaY2RNRGAubk387n40EFuSCBsZ2e-UdFG_u8vxUhZV73-3Pty3W18skPvwfsfc-oF_xvEW2EbH8kTcRzQxIkDM6Ign1VLWsbmqW8WanaAXoTtlx8lfkfhf8rEtUx2mYKlQREtnwliaWIsaP6L8_GcVjxrgp6JSnNWPCstmr8twtqQmpkb-d6EOwXhcHNpFIsD5BJtardm1Nr0wMDZ9C80kOcMmjofsPyrWfHRgY4XRl_04jXl3ODJnDY5G-he3l33z-gqsJCt5OFjAVN4tA5RAi-oBQjxauh1GeE3PFxDXYigliFIa3Bo-5NSBmXwwhrwZ-R-Lfrsi4qwNsb6PNbREv08tJZUDGMdqRYbHIr9Si7AOSXOhIRlGPoKTyzDKfT24ZyL1jGUYCkFaCxwlmCIZb4rVDo7HV57Q3jPud6Q0Je8JiWf6Wnk5qJHaVoFLSNOmfK0El-u9oEC-SRRWywLYfJFj1bLxyYaZUo30oGRrT_44eDKhxnKgJ4Ee0Mw-AfsBFi6GoEuS5jgIkSOPNONVqaPax1ZtKSAn2EqjnA_IFL8B1Al5KtNnrg_PG_y64cmDD2auCtKqigJioTX_uCL3-gLcVfhVV2El7IgrFzuwA6sHYQ-SBAt3EYy0cmwAlPpAV3OyeJ-dilhFOOjhXrAhu3djrSSW-mYwGF2dcseZyADGAzxXrXu8XG3c9X72k3WNtmBdYtHAeNFZhHKIJoN4wgULdfE4RMXgjqOOQ3Sm91mdwGD_tBEFVLwIxKathMUUDtNVrBV0KJ0TrPr3TKU6Do8G3vgakLdZ-LjrCqBXyaFd3zVEYfJghcT4EnHRbqiS44qSLFMBpOY1KUIaSp0WWoFEYQpagq4v-lUKjeCKjE2HmiMLh3UUkqIxx9PiWWPbIthFVo9WlpVpRvLmsGMel5Ag96oVoXPgJaR2a1oVdgRVIFW6Y1slVplUAX-RSxzXoXNgJaRkys0qggkgJ67uFUwTQlS4Lbt4NePSsvCnI46O_SbBGWZ4DmEDnZAWiXBC1w2GcMuU2rHdZOgRu-JIQt0hRcQValpcUlRpi14vU4FauoKnmyvt2v02MydNBmzpC-CqQpmy5fGpElFiyQriDCoQjNEWVCFCdIXdGRaEq3srGpE5rqWTEehAbb96NnDOtEiD_5mgvSWjneQC-_heAcySVm6gBZb0VVFIoKqhR4lLSns65AehP02Itjf3kYBu93bKNAZURF2P5-JLOP2i9OP-E6Gasb3haGqHn5yocOrKaQ32L0Cne4MKQn94J80360V-xPgt9HCzRPxaQrrkFpuGZVqVexYmxYbKFc0lPV_dldfrdCWvtbvLYRgGD8tzhfXoJRcLnNKTAcvmvWctxEsvr6wDrGCXkosbzY13WFM7aI8S19He14YAFFaLjzCcnHwJinpBrIUnYO9ePZHp6DxDSV0b2C07w3_SF9MzaoLMLfEiqDpz9vZV3RXIAMHt5733JD4rumw-y6wSogXjuBsd3EXttykE3mYtqoKbwgtRZcMraUYqqS2JMXghZYs8CLfknVFV1qypGhqS5YV-EcTNK0lSLqot2RREPSWyuuG0QJEnm-JhsKLLYXXgIAiiZrYEiVJbomCqPMtVZRVuSWoMryUFNUATqIiS_AvbyBTHQQQRVloCboOwgiyJsrwUgaCEq-0RE2DfwVNV-SWZmgosyDAY5kHGSRd11sCr8o6YEjAQBAFXWopmiaAVLKuwnMQUcZ_QUJDBlKqbBg8AkI7JV6DliuyoQOIIRpiSxBUEF-QFcloiYoutiRBkoG_oooKyClAg6ANEigHfggqrwIsCAsKAgRBh2YY0FhRVEAKQeM1IKvrKuiDPtGRrCwbEtDlJWBEayeodFCLKELLAAuotESel5GODqIqhoYmATRQJogA2pVF0Jos8SCfrgpqSxUMtCYvK2ASEBLEM1R4Iioqj3CIKUgSaEPTBQmVpwFdRQbbKRKC0xoTEABtgzV1MI8qGgbYmtdAn7KmKKgD-CnIoFNRhTaDTTRQmAjaB6bQMDAp2BhY65qGOOA7AIgsQH4ZlQPqAD-QgIqq0YYBGjQMIeGdikKCMUFIQwFfkSVogM4rYElwD9AbsFJahgZigVpA5aIoAgsNRAGWEqoLEME8oGuwow7_SgZYQ9I1Ef1VQGtIaHAJVKm3DGy4yOvARsD703EbdAB9aB7NXbBCRW-OT_csMX5GC2VxVf4GEp-2b_3ueRMsO7Dq13X_jO0THofhNNjf23t6etqdmuHYG5Fn2yG7ljfZmwItiAM7tJizg911rw3_Hd63O-NH5Ug5lDyj92R4R3Njbnpy98aWB1e_dae9u1C-HT9Zf2gnR8P2b52-ctW7_NL-cnhyZp3qo6Pe5PxBf-oPhl1l3J5_Pz5zgovrm53T-eW39pPj7fzenk5O5fBMGY3vJt2Hb_fzz3_YA-N2KD_enN5_EQL791FH_O3iPPh07E6fL7-4Z8JnxW13vn10vo34rnd-ev7lkJwZ0scd5fHiJvz14bu60x1-79_uqJ3eTf_xVO8q5-eOPx18kj7d-s9EUsefeua3-cfbs-nTOPjU_jQeaMr3q_CrfCKefLt8Ivzt88lX_uH2txuX31Genm703_nD4_vjzvRWOulKmnrc_T52e58Nvr8zbJ9fn9yoX25m6kdd1vxP15dPgnv3-8dfH9R-_-PDb_b809W8832-8-u3U01qX8_Ov-yYDv_t-1y-7NnHT9_kr8eji8MAtP3hA9u5HFssqnwGURkTxxffHrJiIvydzEvjF1hx-8ziKu65D6PfLJaw7sD8kUVE5s4sSLGoy0IK6-4seLBIyfoM64QsENJozPpfFFlYLKDxmfUWFhVpgGShmsYxFuRotGDdmXZWvMbqORY93sCdae_BHg5LdADDcQt_0FIrIOI1RmY0T3RgLBqMvSd20Bm5gowhSIZZczqFQSpVnD3Yu4R-cDGigy1kLOIvjf8D7wM71g==

Before screenshot:

image image

After screenshot:

image image
image

@Peechey Peechey added the bug: calculation Numerical differences label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inexorable Critical II wrongly reduces Critical Hit Chance instead of Critical Damage Bonus

1 participant