Fixed a variety of incorrect catalyst scaling#4467
Merged
LocalIdentity merged 16 commits intoFeb 18, 2023
Merged
Conversation
The changes are based off some testing and work I did in 17/4/2021 So any recently changed mods or new uniques will not be guaranteed to be correct. PathOfBuildingCommunity#2521 (comment) https://docs.google.com/spreadsheets/d/11mOp3VLPXgbhJq562DdFmP34nx4tNqoF47LbrM-R93g/edit#gid=0 I have verified all of these either using trade or through in game but I haven't collated documentation due to the large number of changes.
fix accidently removing jewellery res from Tavukai
2 tasks
Member
|
For whoever looks at this, the tags being wrong can be fixed generically with #2662 even if we just run the scripts once to clean everything up. I'm sure there are other uniques with the wrong tags that no one has noticed/reported |
Contributor
Author
|
I am down to run the script and then just cleanup the remaining few it missed/got wrong. (rare cases of unscalable values) Noxious catalyst still needs to be fixed but that could be split into a separate pull request. |
QuickStick123
added
bug
LocalIdentity
approved these changes
Dec 8, 2022
Contributor
Author
|
I want to review the mods again. Don't merge this yet. |
^(\{variant:.+?\})?(\{tags:.+?\})?([^{}]+?)% to (.+?) Resistance
$1{tags:jewellery_resistance}$3% to $4 Resistance
Contributor
Author
|
This is good for review again. |
\{tags:(.+)\}\{variant:(.+)\}
{variant:$2}{tags:$1}
3 tasks
3 tasks
LocalIdentity
approved these changes
Feb 18, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…y#4467) * Fixed a variety of incorrect catalyst scaling The changes are based off some testing and work I did in 17/4/2021 So any recently changed mods or new uniques will not be guaranteed to be correct. PathOfBuildingCommunity#2521 (comment) https://docs.google.com/spreadsheets/d/11mOp3VLPXgbhJq562DdFmP34nx4tNqoF47LbrM-R93g/edit#gid=0 I have verified all of these either using trade or through in game but I haven't collated documentation due to the large number of changes. * Update amulet.lua fix accidently removing jewellery res from Tavukai * Update Noxious to damage * Couple minor fixes to legacy voidheart and forgeting to readd chaos to Lori lantern * fix missing updating physical damage on unique belts. * fix typo * Just make the resistances a bit cleaner ^(\{variant:.+?\})?(\{tags:.+?\})?([^{}]+?)% to (.+?) Resistance $1{tags:jewellery_resistance}$3% to $4 Resistance * Cleanup and fix leech * Fix typo * Fixup missing speed tags * Variants Before Tags \{tags:(.+)\}\{variant:(.+)\} {variant:$2}{tags:$1} * Rotblood * Update ring.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current plan with this is to run #2662 and then fixed the last few mistakes in here detailed in #2662 (comment).
The changes are based off some testing and work I did in 17/4/2021
So any recently changed mods or new uniques will not be guaranteed to be correct.
#2521 (comment)
https://docs.google.com/spreadsheets/d/11mOp3VLPXgbhJq562DdFmP34nx4tNqoF47LbrM-R93g/edit#gid=0
Further fixes i did was fixing noxious catalyst to scale physical and chaos damage instead of generic tags.
Fixes #3193 #2843 #2521 #4482 #5614 #5688
Description of the problem being solved:
Catalyst scaling is incorrect in a number of cases.
Steps taken to verify a working solution:
I have verified all of these either using trade or through in game but I haven't collated documentation due to the large number of changes.