Changes for luaPoB to support pyPoB's build xmls#4758
Closed
pHiney wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Nothing.
Accumulation PR of needed adjustments (hopefully, just this one)
Description of the problem being solved:
1. NotesHTML tag
pyPob or (PyPob) introduces a NotesHTML xml tag which would be lost if the build.xml was loaded into the lua version.
Steps taken to verify a working solution:
1. NotesHTML tag
Link to a build that showcases this PR:
1. NotesHTML tag
https://pastebin.com/cjxaAMW
Before screenshot:
1. NotesHTML tag
N/A
After screenshot:
1. NotesHTML tag
N/A