Skip to content

Support Foulborn Choir of the Storm and Skin of the Loyal/Lords#9255

Closed
Mef1729 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
Mef1729:support_foulborn_mods
Closed

Support Foulborn Choir of the Storm and Skin of the Loyal/Lords#9255
Mef1729 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
Mef1729:support_foulborn_mods

Conversation

@Mef1729
Copy link
Copy Markdown

@Mef1729 Mef1729 commented Nov 14, 2025

Description of the problem being solved:

Mana increased by 50% of overcapped lightning resistance is not supported
50% increased elemental and chaos resistances are not supported

Steps taken to verify a working solution:

  • imported the build
  • checked resistances and mana against in-game values
  • ran tests via docker-compose

Link to a build that showcases this PR:

https://poe.ninja/poe1/builds/keepers/character/RavusLupus-5637/NonFar%C3%A0

Before screenshot:

image ### After screenshot: image

@Mef1729
Copy link
Copy Markdown
Author

Mef1729 commented Nov 16, 2025

This does not work - it does not factor in a number of things (e.g. Purity skills) as a consequence of moving the calculation of resistances that early.

I do have a fix that I can use locally, but it is an ugly hack that conditionally repeats doActorLifeMana and doActorLifeManaReservation. Foulborn Skin support works on its own, but it's a simple one-liner.

@Mef1729 Mef1729 closed this Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant