Support Foulborn Choir of the Storm and Skin of the Loyal/Lords#9255
Closed
Mef1729 wants to merge 1 commit into
Closed
Support Foulborn Choir of the Storm and Skin of the Loyal/Lords#9255Mef1729 wants to merge 1 commit into
Mef1729 wants to merge 1 commit into
Conversation
Author
|
This does not work - it does not factor in a number of things (e.g. Purity skills) as a consequence of moving the calculation of resistances that early. I do have a fix that I can use locally, but it is an ugly hack that conditionally repeats doActorLifeMana and doActorLifeManaReservation. Foulborn Skin support works on its own, but it's a simple one-liner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Mana increased by 50% of overcapped lightning resistance is not supported
50% increased elemental and chaos resistances are not supported
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe1/builds/keepers/character/RavusLupus-5637/NonFar%C3%A0
Before screenshot: