-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Auto-heal for silent semantic search failure #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule internal-docs
updated
from 559dfa to 3ba26e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** | ||
| * Thrown when the LanceDB index is corrupted or has a schema mismatch. | ||
| * This error signals that re-indexing is required for semantic search to work. | ||
| */ | ||
| export class IndexCorruptedError extends Error { | ||
| constructor(message: string) { | ||
| super(message); | ||
| this.name = 'IndexCorruptedError'; | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'; | ||
| import { promises as fs } from 'fs'; | ||
| import os from 'os'; | ||
| import path from 'path'; | ||
| import { IndexCorruptedError } from '../src/errors/index.js'; | ||
|
|
||
| const lancedb = vi.hoisted(() => ({ | ||
| connect: vi.fn() | ||
| })); | ||
|
|
||
| vi.mock('@lancedb/lancedb', () => ({ | ||
| connect: lancedb.connect | ||
| })); | ||
|
|
||
| describe('LanceDBStorageProvider corruption detection', () => { | ||
| let tempDir: string; | ||
| let consoleErrorSpy: ReturnType<typeof vi.spyOn>; | ||
|
|
||
| beforeEach(async () => { | ||
| tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'lancedb-test-')); | ||
| lancedb.connect.mockReset(); | ||
| consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {}); | ||
| }); | ||
|
|
||
| afterEach(async () => { | ||
| consoleErrorSpy.mockRestore(); | ||
| await fs.rm(tempDir, { recursive: true, force: true }); | ||
| }); | ||
|
|
||
| it('throws IndexCorruptedError when vector column missing during initialize()', async () => { | ||
| const dropTable = vi.fn(async () => {}); | ||
| const db = { | ||
| tableNames: vi.fn(async () => ['code_chunks']), | ||
| openTable: vi.fn(async () => ({ | ||
| schema: vi.fn(async () => ({ fields: [{ name: 'id' }] })) | ||
| })), | ||
| dropTable | ||
| }; | ||
|
|
||
| lancedb.connect.mockResolvedValue(db); | ||
|
|
||
| const { LanceDBStorageProvider } = await import('../src/storage/lancedb.js'); | ||
| const provider = new LanceDBStorageProvider(); | ||
|
|
||
| await expect(provider.initialize(tempDir)).rejects.toBeInstanceOf(IndexCorruptedError); | ||
| expect(dropTable).toHaveBeenCalledWith('code_chunks'); | ||
| }); | ||
|
|
||
| it('throws IndexCorruptedError when schema validation fails during initialize()', async () => { | ||
| const dropTable = vi.fn(async () => {}); | ||
| const db = { | ||
| tableNames: vi.fn(async () => ['code_chunks']), | ||
| openTable: vi.fn(async () => ({ | ||
| schema: vi.fn(async () => { | ||
| throw new Error('schema error'); | ||
| }) | ||
| })), | ||
| dropTable | ||
| }; | ||
|
|
||
| lancedb.connect.mockResolvedValue(db); | ||
|
|
||
| const { LanceDBStorageProvider } = await import('../src/storage/lancedb.js'); | ||
| const provider = new LanceDBStorageProvider(); | ||
|
|
||
| await expect(provider.initialize(tempDir)).rejects.toBeInstanceOf(IndexCorruptedError); | ||
| expect(dropTable).toHaveBeenCalledWith('code_chunks'); | ||
| }); | ||
|
|
||
| it('throws IndexCorruptedError when vector search fails with "No vector column"', async () => { | ||
| const { LanceDBStorageProvider } = await import('../src/storage/lancedb.js'); | ||
| const provider = new LanceDBStorageProvider() as any; | ||
|
|
||
| const query = { | ||
| limit: vi.fn(() => query), | ||
| where: vi.fn(() => query), | ||
| toArray: vi.fn(async () => { | ||
| throw new Error('Schema Error: No vector column found to create index'); | ||
| }) | ||
| }; | ||
|
|
||
| provider.initialized = true; | ||
| provider.table = { | ||
| vectorSearch: vi.fn(() => query) | ||
| }; | ||
|
|
||
| await expect(provider.search([0.1, 0.2], 5)).rejects.toBeInstanceOf(IndexCorruptedError); | ||
| }); | ||
| }); | ||
|
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Overly broad error catching - any error matching "LanceDB" or "Arrow" triggers auto-heal
This catch-all may cause unnecessary re-indexing for transient network issues, OOM errors, or other non-corruption problems. Consider narrowing to specific error types or adding additional validation before throwing
IndexCorruptedError.Prompt To Fix With AI