feat: implement KYC expiry, multisig governance, execution guards, an…#171
Merged
Conversation
…d state snapshots - Issue PayCraftt#165: Add expiry for pending KYC requests - Add expires_at field to KYCRecord - Set 30-day default expiry (7-day minimum) - Prevent approval of expired requests - Emit expiry events - Add comprehensive tests - Issue PayCraftt#166: Validate multi-signature governance execution - Track required_signatures and total_signers per proposal - Prevent duplicate signatures - Enforce minimum signature threshold - Enhanced error messages with approval progress - Add comprehensive multisig tests - Issue PayCraftt#167: Prevent double execution of governance proposals - Add Executed status to ProposalStatus enum - Implement execute() method with double-execution guard - Add execute_proposal() to GovernanceVoting - Validate proposal state before execution - Add comprehensive execution guard tests - Issue PayCraftt#168: Enforce consistent state snapshot for critical operations - Create StateSnapshot module with snapshot pattern - Implement AtomicOperation for state-consistent execution - Add StateConsistencyChecker for validation - Create ReadConsistencyGuard for read consistency - Add comprehensive state snapshot tests
|
@memplethee-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d state snapshots
: Add expiry for pending KYC requests