Skip to content

Explicitly mark null parameters as nullable #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierredup merged 1 commit into from
Jun 3, 2025
Merged

Explicitly mark null parameters as nullable #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Action/GetHttpRequestAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ class GetHttpRequestAction implements ActionInterface
/**
* @deprecated
*/
public function setHttpRequest(Request $httpRequest = null): void
public function setHttpRequest(?Request $httpRequest = null): void
{
$this->httpRequest = $httpRequest;
}

public function setHttpRequestStack(RequestStack $httpRequestStack = null): void
public function setHttpRequestStack(?RequestStack $httpRequestStack = null): void
{
$this->httpRequestStack = $httpRequestStack;
}
Expand Down
4 changes: 2 additions & 2 deletions Action/ObtainCreditCardAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ public function __construct(FormFactoryInterface $formFactory, $templateName)
/**
* @deprecated
*/
public function setRequest(Request $request = null): void
public function setRequest(?Request $request = null): void
{
$this->httpRequest = $request;
}

public function setRequestStack(RequestStack $requestStack = null): void
public function setRequestStack(?RequestStack $requestStack = null): void
{
$this->httpRequestStack = $requestStack;
}
Expand Down