support default primary key detection for mysql for int/temporal types#4440
support default primary key detection for mysql for int/temporal types#4440jgao54 wants to merge 1 commit into
Conversation
ea632d8 to
f1df47e
Compare
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
❌ Test FailureAnalysis: The PR's own new test Test_MySQL_Default_Partition_Key_Parallel_Snapshot deterministically times out during snapshot (STATUS_SNAPSHOT) in multiple matrix legs, indicating a real bug in the new MySQL default-partition-key parallel-snapshot feature rather than flakiness. |
f1df47e to
57e75a7
Compare
🔄 Flaky Test DetectedAnalysis: The test failed on a non-retried assertion (require.Greater, "1 is not greater than 1") that races against Temporal's eventually-consistent ListWorkflow visibility indexing, and failed in only one of several parallel matrix jobs—both hallmarks of a flaky timing race rather than a real bug. ✅ Automatically retrying the workflow |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
When custom partition key is not specified, determine default partition key based on table's primary key. If the primary key(s) starts with an integer or temporal type, perform parallel snapshot instead of full table snapshot.
Testing: