feat(mysql): introduce a testcontainer for binlog incident event#4442
feat(mysql): introduce a testcontainer for binlog incident event#4442ilidemi wants to merge 6 commits into
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
🔄 Possible Flaky TestAnalysis: The new Test_MySQL_BinlogIncident test failed with a transient MySQL handshake EOF ("connection was bad") after deliberately disrupting the server, which looks like a reconnect race/network error—but since it's a brand-new testcontainer test with no green history, a deterministic setup bug can't be ruled out. |
🔄 Flaky Test DetectedAnalysis: Flaky failure: the unrelated MongoDB test TestApiMongo/TestCancelErrorOnPostgresZeroOIDs failed in only one matrix job because MongoDB's serverStatus transiently reported oplog retention as 23h despite CI configuring --oplogMinRetentionHours 24, an environment quirk unrelated to the PR's MySQL binlog changes. ✅ Automatically retrying the workflow |
Test binlog
INCIDENT_EVENTe2e with a MySQL debug image (#4441) in a testcontainer. Tweaking the args brought memory usage from 300MB -> 130MB on my machine. Test is ran for mysql-pos and mysql-gtid (but not maria), also excluding ch-cluster as we're only testing the source.