Skip to content

feat(mysql): introduce a testcontainer for binlog incident event#4442

Open
ilidemi wants to merge 6 commits into
mainfrom
fix/dbi-814/mysql-handle-binlog-incident-event-with-test
Open

feat(mysql): introduce a testcontainer for binlog incident event#4442
ilidemi wants to merge 6 commits into
mainfrom
fix/dbi-814/mysql-handle-binlog-incident-event-with-test

Conversation

@ilidemi

@ilidemi ilidemi commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Test binlog INCIDENT_EVENT e2e with a MySQL debug image (#4441) in a testcontainer. Tweaking the args brought memory usage from 300MB -> 130MB on my machine. Test is ran for mysql-pos and mysql-gtid (but not maria), also excluding ch-cluster as we're only testing the source.

@ilidemi ilidemi requested a review from a team as a code owner June 18, 2026 06:14
@claude

claude Bot commented Jun 18, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2278 2 2276 217
View the top 2 failed test(s) by shortest run time
github.com/PeerDB-io/peerdb/flow/e2e::TestApiMongo
Stack Traces | 0.02s run time
=== RUN   TestApiMongo
=== PAUSE TestApiMongo
=== CONT  TestApiMongo
--- FAIL: TestApiMongo (0.02s)
2026/06/18 08:03:10 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/06/18 08:03:10 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mychcl_oy49vtha.test_skip_snapshot
2026/06/18 08:03:10 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mychcl_xbclcxea.test_time
github.com/PeerDB-io/peerdb/flow/e2e::TestApiMongo/TestCancelErrorOnPostgresZeroOIDs
Stack Traces | 0.07s run time
=== RUN   TestApiMongo/TestCancelErrorOnPostgresZeroOIDs
=== PAUSE TestApiMongo/TestCancelErrorOnPostgresZeroOIDs
=== CONT  TestApiMongo/TestCancelErrorOnPostgresZeroOIDs
2026/06/18 08:01:53 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
    cancel_table_addition_test.go:1018: 
        	Error Trace:	.../flow/e2e/cancel_table_addition_test.go:1018
        	Error:      	Received unexpected error:
        	            	rpc error: code = Internal desc = invalid mirror: rpc error: code = FailedPrecondition desc = failed to validate source connector mongo: oplog retention must be set to >= 24 hours, but got 23.000000
        	Test:       	TestApiMongo/TestCancelErrorOnPostgresZeroOIDs
    api_test.go:51: begin tearing down postgres schema api_78bv1gx4
--- FAIL: TestApiMongo/TestCancelErrorOnPostgresZeroOIDs (0.07s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Possible Flaky Test

Analysis: The new Test_MySQL_BinlogIncident test failed with a transient MySQL handshake EOF ("connection was bad") after deliberately disrupting the server, which looks like a reconnect race/network error—but since it's a brand-new testcontainer test with no green history, a deterministic setup bug can't be ruled out.
Confidence: 0.5

⚠️ Confidence too low (0.5) to retry automatically - manual review recommended

View workflow run

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: Flaky failure: the unrelated MongoDB test TestApiMongo/TestCancelErrorOnPostgresZeroOIDs failed in only one matrix job because MongoDB's serverStatus transiently reported oplog retention as 23h despite CI configuring --oplogMinRetentionHours 24, an environment quirk unrelated to the PR's MySQL binlog changes.
Confidence: 0.9

✅ Automatically retrying the workflow

View workflow run

@ilidemi ilidemi changed the title fix(mysql): handle binlog incident event, introduce a testcontainer feat(mysql): introduce a testcontainer for binlog incident event Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants