You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The call_api() function unconditionally echoes the full JSON payload to stdout:
echo"Payload: $_call_api_payload"
Every calling script passes payloads containing credentials — PG_PASSWORD, CI_MYSQL_ROOT_PASSWORD, CI_MONGO_PASSWORD, AWS_SECRET_ACCESS_KEY, etc. In the Tilt dev environment, this output is captured and displayed in the Tilt UI logs.
Changes should not include addition of outputs through stdout, stderr or logs that might contain PII or Secret information. Play special attention to printing passwords and access tokens.
Suggested fix: Remove line 13 (echo "Payload: $_call_api_payload") from flow_api_call.sh. The endpoint and method are already logged on line 12, which is sufficient for debugging without exposing secrets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.