Switch versioneer integration to build-time dependency mode#24
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project's version management from a hardcoded version string to dynamic versioning using Versioneer in build-time dependency mode. Instead of vendoring Versioneer's helper code, the project now declares versioneer[toml] as a build requirement and generates the _version.py file to compute version numbers from Git metadata.
Key changes:
- Replaced hardcoded version with dynamic Git-based versioning
- Added Versioneer configuration in pyproject.toml
- Generated _version.py for runtime version computation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/heyfastqlib/_version.py | Generated Versioneer module that computes version from Git metadata |
| src/heyfastqlib/init.py | Updated to import and use version from _version.py instead of hardcoded string |
| pyproject.toml | Added versioneer[toml] build dependency and Versioneer configuration |
| .gitattributes | Configured Git export-subst for _version.py to enable tarball versioning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f90c53560c8323a42629569bd1eb31