Skip to content

Switch versioneer integration to build-time dependency mode#24

Merged
Ulthran merged 2 commits intomainfrom
codex/replace-hardcoded-version-with-versioneer
Oct 22, 2025
Merged

Switch versioneer integration to build-time dependency mode#24
Ulthran merged 2 commits intomainfrom
codex/replace-hardcoded-version-with-versioneer

Conversation

@Ulthran
Copy link
Contributor

@Ulthran Ulthran commented Oct 22, 2025

Summary

  • remove the vendored versioneer helper in favor of build-time dependency mode
  • declare versioneer[toml] as a build requirement so packaging can import Versioneer

Testing

  • pytest

https://chatgpt.com/codex/tasks/task_e_68f90c53560c8323a42629569bd1eb31

Copilot AI review requested due to automatic review settings October 22, 2025 17:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project's version management from a hardcoded version string to dynamic versioning using Versioneer in build-time dependency mode. Instead of vendoring Versioneer's helper code, the project now declares versioneer[toml] as a build requirement and generates the _version.py file to compute version numbers from Git metadata.

Key changes:

  • Replaced hardcoded version with dynamic Git-based versioning
  • Added Versioneer configuration in pyproject.toml
  • Generated _version.py for runtime version computation

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/heyfastqlib/_version.py Generated Versioneer module that computes version from Git metadata
src/heyfastqlib/init.py Updated to import and use version from _version.py instead of hardcoded string
pyproject.toml Added versioneer[toml] build dependency and Versioneer configuration
.gitattributes Configured Git export-subst for _version.py to enable tarball versioning

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Ulthran Ulthran merged commit 9e29178 into main Oct 22, 2025
4 checks passed
@Ulthran Ulthran deleted the codex/replace-hardcoded-version-with-versioneer branch October 22, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants