Update Slurm benchmarking script for paired FASTQ inputs#25
Update Slurm benchmarking script for paired FASTQ inputs#25
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Slurm benchmarking script for heyfastq that handles paired FASTQ inputs. The script automates the submission of multiple benchmarking jobs with different thread counts and compression levels.
- Hardcoded paired FASTQ input paths with automatic output path derivation
- Automated Slurm job submission across configurable thread and compression combinations
- Job ID collection and tracking from sbatch submissions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Path("/path/to/input_R1.fastq.gz"), | ||
| Path("/path/to/input_R2.fastq.gz"), |
There was a problem hiding this comment.
The hardcoded placeholder paths '/path/to/input_R1.fastq.gz' and '/path/to/input_R2.fastq.gz' should be replaced with actual paths or made configurable through command-line arguments or environment variables to make the script usable without modification.
| *(str(path) for path in inputs), | ||
| "--output", | ||
| *(str(path) for path in outputs), |
There was a problem hiding this comment.
[nitpick] The generator expressions are unpacked directly into command_parts. Convert these to lists using list() to avoid potential issues with generator exhaustion and improve code clarity: *[str(path) for path in inputs] and *[str(path) for path in outputs].
| *(str(path) for path in inputs), | |
| "--output", | |
| *(str(path) for path in outputs), | |
| *[str(path) for path in inputs], | |
| "--output", | |
| *[str(path) for path in outputs], |
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f92aaf07e483239cc602c4c14e3c27