Skip to content

Update Slurm benchmarking script for paired FASTQ inputs#25

Open
Ulthran wants to merge 1 commit intomainfrom
codex/add-benchmarking-script-for-slurm
Open

Update Slurm benchmarking script for paired FASTQ inputs#25
Ulthran wants to merge 1 commit intomainfrom
codex/add-benchmarking-script-for-slurm

Conversation

@Ulthran
Copy link
Contributor

@Ulthran Ulthran commented Oct 22, 2025

Summary

  • hardcode a paired FASTQ input list and derive matching OUT_ outputs
  • submit Slurm jobs across thread/compression combinations while collecting job IDs

Testing

  • python -m compileall scripts/benchmark_slurm.py

https://chatgpt.com/codex/tasks/task_e_68f92aaf07e483239cc602c4c14e3c27

Copilot AI review requested due to automatic review settings October 22, 2025 19:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a Slurm benchmarking script for heyfastq that handles paired FASTQ inputs. The script automates the submission of multiple benchmarking jobs with different thread counts and compression levels.

  • Hardcoded paired FASTQ input paths with automatic output path derivation
  • Automated Slurm job submission across configurable thread and compression combinations
  • Job ID collection and tracking from sbatch submissions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +13 to +14
Path("/path/to/input_R1.fastq.gz"),
Path("/path/to/input_R2.fastq.gz"),
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded placeholder paths '/path/to/input_R1.fastq.gz' and '/path/to/input_R2.fastq.gz' should be replaced with actual paths or made configurable through command-line arguments or environment variables to make the script usable without modification.

Copilot uses AI. Check for mistakes.
Comment on lines +34 to +36
*(str(path) for path in inputs),
"--output",
*(str(path) for path in outputs),
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The generator expressions are unpacked directly into command_parts. Convert these to lists using list() to avoid potential issues with generator exhaustion and improve code clarity: *[str(path) for path in inputs] and *[str(path) for path in outputs].

Suggested change
*(str(path) for path in inputs),
"--output",
*(str(path) for path in outputs),
*[str(path) for path in inputs],
"--output",
*[str(path) for path in outputs],

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants