Fix deserialization of functions#16
Merged
Merged
Conversation
denialhaag
force-pushed
the
fix-function-deserialization
branch
from
c6dfe71 to
4016233
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the deserialization of functions by no longer relying on the index of the function name, as required by the spec: https://github.com/unitaryfoundation/jeff/blob/8bee28ef974b928f00465f316425d22548c0e7e8/impl/capnp/jeff.capnp#L1497-L1498
I came across this bug while trying to create the issue promised in #14 (comment). While the Python builder does like to mix up the order of the strings, it does not create faulty
jeffmodules.