fix(molecule): repair destroy playbook paths so package-testing teardown runs#1144
Open
nogueiraanderson wants to merge 2 commits into
Open
fix(molecule): repair destroy playbook paths so package-testing teardown runs#1144nogueiraanderson wants to merge 2 commits into
nogueiraanderson wants to merge 2 commits into
Conversation
…own runs - 14 EC2 molecule scenarios (pxc, pxb-package-testing) referenced their destroy playbook at the wrong relative depth, so `molecule destroy` resolved to a missing file and silently no-oped, leaking instances on every failed run. Each path is corrected to resolve to the suite's existing destroy playbook (including the doubly-nested pxc rhel-10/rhel-9, which needed one more level). - ps/debian-13 had destroy commented out of the provisioner and sequences; re-enabled to match its working siblings. - ps80-binary-tarball is fixed separately in PR Percona-QA#1138 and is left untouched.
- molecule/pxc/pxc84-common-min_upgrade/molecule/rhel-10/rhel-9 is an accidental double-nest: a rhel-10 scenario dir holding a second rhel-9 scenario whose name collides with the real rhel-9 sibling. - Molecule discovers scenarios one level deep (molecule/<name>/), so the nested dir is never run; the valid rhel-9 sibling already covers RHEL 9. - Supersedes the destroy-path patch this PR applied to that file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
destroyplaybook at the wrong relative depth, somolecule destroyresolves to a missing file and silently no-ops, leaking the run's instances on failure.ps/debian-13hasdestroycommented out entirely, with the same effect.Fix
destroy:path to resolve to the suite's existing destroy playbook, computed per scenario rather than blanket-edited.destroyinps/debian-13to match its working siblings.pxcrhel-10/rhel-9nested scenario (arhel-10dir holding a secondrhel-9that Molecule never discovers, colliding with the realrhel-9sibling) instead of path-patching a dead scenario.Tickets
ps80-binary-tarballis fixed separately in fix(ps80-binary-tarball): tear down molecule EC2 instances on failure #1138 (adds the missingplaybooks/destroy.yml); together they close the ec2 teardown-leak class.