Proposal: change CSV format#5
Draft
dutow wants to merge 1 commit into
Draft
Conversation
Currently the CSV format is limited by: * adding many information about the test setup into a single field, instead of using separate columns for the separate features * doesn't include some parameters used during the run, such as the PG_TDE variable This is just a draft/proposal, not an actual ready to be merged PR, as it only hardcodes the PG_TDE variable instead of providing something more generic, I just want to validate the idea with it first. The usecase for this script is that a separete simple CSV processing script can go through the CSV files, and upload them to a database used by grafana, without: * relying on information not existing in the csv, such as shell variables * doing extensive string processing to try to recover all the information which was put into a single field Toughts?
Collaborator
|
Toughts:
and a set of parameters which are duplicated now. |
Contributor
Author
|
We could also store the parameters in a separate file in the same directory, and then the upload script could read that too - bu currently I don't see a file like that. We have My main reason for this change was:
And maybe I could include the separate branh/commit/time fields in that file too. What do you think about that approach? |
Collaborator
|
db56942 to
f828ce6
Compare
ef1afbd to
8a58bd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the CSV format is limited by:
This is just a draft/proposal, not an actual ready to be merged PR, as it only hardcodes the PG_TDE variable instead of providing something more generic, I just want to validate the idea with it first.
The usecase for this script is that a separete simple CSV processing script can go through the CSV files, and upload them to a database used by grafana, without:
Toughts?