Optimizations in _parse_fh#4
Open
dolmen wants to merge 7 commits into
Open
Conversation
The regexp was parsing "package xx::3;" as package "xx", version "3"
Non-ASCII char in comment at line 83.
Member
|
Thanks for this PR, and I will review it, but Module::Metadata is undergoing a near-complete rewrite right now, so performance optimizations are a bit premature and will need to be redone afterwards anyway :) Thanks for the poke though, and I'll endeavour shortly to return to my work here that was being done at QAH. |
Member
Member
Author
karenetheridge
force-pushed
the
master
branch
from
cde0417 to
5f26c2a
Compare
karenetheridge
force-pushed
the
master
branch
5 times, most recently
from
f32f0dc to
669d23b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple small optimizations.