Skip to content

test(hir): fix cheerio_call_rewrite compile on main (missing byte_offset after #5250)#5266

Merged
proggeramlug merged 2 commits into
mainfrom
fix/cheerio-test-byte-offset
Jun 16, 2026
Merged

test(hir): fix cheerio_call_rewrite compile on main (missing byte_offset after #5250)#5266
proggeramlug merged 2 commits into
mainfrom
fix/cheerio-test-byte-offset

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

#5250 added Expr::Call.byte_offset but missed updating crates/perry-hir/tests/cheerio_call_rewrite.rs, so cargo test -p perry-hir fails to compile on main (error[E0063]: missing field byte_offset ×3). This adds byte_offset: 0 to the 3 Expr::Call constructions. Test compiles + passes. No src changes.

Summary by CodeRabbit

  • Tests

    • Updated internal test fixtures for expression call rewrites to include an additional byte_offset field.
    • Minor fixture structure improvements; no changes to test assertions or execution logic.
  • User Impact

    • No user-facing changes in this release.

…e (fix main test compile after #5250)

#5250 added Expr::Call.byte_offset but missed this integration test → cargo test -p perry-hir
failed to compile on main. Add byte_offset: 0 to the 3 Expr::Call constructions.
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e6c7788-24a4-4ab3-af83-b02fccc3c40a

📥 Commits

Reviewing files that changed from the base of the PR and between 07ff935 and 757b563.

📒 Files selected for processing (1)
  • crates/perry-hir/tests/cheerio_call_rewrite.rs
✅ Files skipped from review due to trivial changes (1)
  • crates/perry-hir/tests/cheerio_call_rewrite.rs

📝 Walkthrough

Walkthrough

Three byte_offset: 0 field initializers are added to Expr::ExternFuncRef and Expr::Call struct literals inside the non_native_fluent_chains_are_walked_linearly test fixture. No assertions or control flow are changed.

Changes

Cheerio Call Rewrite Test Fixture

Layer / File(s) Summary
byte_offset field additions in test expressions
crates/perry-hir/tests/cheerio_call_rewrite.rs
Adds byte_offset: 0 to three expression struct literals (Expr::ExternFuncRef at line 108, loop Expr::Call at line 123, and the .strict Expr::Call at line 134) in the non_native_fluent_chains_are_walked_linearly test to satisfy the updated struct definition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A field called byte_offset, so shy,
Tucked into three structs on the fly.
No logic was broken,
No assertion was spoken—
Just zero, times three, hopping by!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing a compilation issue in the test file due to a missing field after PR #5250.
Description check ✅ Passed The description provides a clear summary of the issue and the fix, explaining that PR #5250 introduced a new byte_offset field that was missed in this test file.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cheerio-test-byte-offset

Comment @coderabbitai help to get the list of available commands and usage tips.

@proggeramlug proggeramlug merged commit 8684e34 into main Jun 16, 2026
13 of 15 checks passed
@proggeramlug proggeramlug deleted the fix/cheerio-test-byte-offset branch June 16, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant