Conversation
This implements the core logic around match states, though is untested. There's no support here yet for making edits.
This is largely copied over from srcomp-http in order to centralise the logic and enable easier changes.
While *mostly* we want this to be the current time, there are cases where we want to freeze the current time for several requests. This is particularly the case in srcomp-http for example.
This introduces (horror!) the idea of an "effective time" which advances only as far as the next unreleased match's release threshold.
There isn't really any need for that to be the case, even if that's the intended use-case. Certainly nothing about the logic actually relies on that being the case.
Now that we have operational considerations on top of the schedule, this would return a misleading view of the matches at a given time. If it turns out that we need a view of the originally scheduled matches at a given time we can reintroduce it, though with a clearer name (likely `matches_scheduled_at`).
With how this is currently implenented (especially in the opt-out case) there isn't really a way to have this validation. It's also unclear whether or not this is useful.
This was referenced Jan 18, 2026
Not strictly something we need, however since we validate our minimum dependencies actually work this is needed for that to pass.
PeterJCLaw
force-pushed
the
match-release
branch
from
c3c2156 to
bd9aa94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the idea that a match needs to be "released" before it can actually run.
This does not change the schedule times, which are what remain published. Instead we adjust the idea of what the "current" match is and mark each match with a state (
released,heldorfuture).This needs changes from other parts of the ecosystem to work and thus may warrant a major release number.
Related changes:
TODO (this PR):
TODO (general):