Allow onException timer handler to catch exceptions thrown in async m…#106
Open
SebastianBienert wants to merge 1 commit intoPeterKottas:masterfrom
Open
Allow onException timer handler to catch exceptions thrown in async m…#106SebastianBienert wants to merge 1 commit intoPeterKottas:masterfrom
SebastianBienert wants to merge 1 commit intoPeterKottas:masterfrom
Conversation
Owner
|
Thanks! I am rly busy with other stuff right now so it's taking a while to react to these. It makes sense and I am all for improving debug experience. I kind of dislike the repetition in code this brings. Would be great if this could have been handled with one approach. I might look into this further to see if I can find a better solution, but if not, I'll be happy to merge and release this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow onException timer handler to catch exceptions thrown in async methods
Developing my service I came across problem which took me a while to debug. The problem is that when someone passes async lambda method to
Timer onStarthandler -onExceptionhandler will not be triggered. I believe it's because of the type ofonStarthandler wchich isAction. One solution would be to just wrap body of lambda function in additional try catch block:But it does not feel right with a method which exposes explicit handler for this.