Fix short imports deprecation #39
Open
mukaschultze wants to merge 1 commit intoPeterStaev:masterfrom
mukaschultze:master
Open
Fix short imports deprecation #39mukaschultze wants to merge 1 commit intoPeterStaev:masterfrom mukaschultze:master
mukaschultze wants to merge 1 commit intoPeterStaev:masterfrom
mukaschultze:master
Conversation
Owner
|
Hey @mukaschultze , first of all thank you for your contribution! I am aware that the {N} core team is depreciating those short import paths and are pushing all devs to write the full path which seems ridiculous as you have to type an additional 31 symbols for every import. You can read more details on the discussion/suggestions here: NativeScript/NativeScript#4041 (comment) So for the time being I'm not going to take any actions on fixing this, until the core team decides how will they proceed with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append the
tns-core-modules/prefix to modules import to prevent errors on compilation due to short imports deprecation