Skip to content

Feature: Add Dragonflight Expansion Summary & TWW Delves tracking#465

Open
HectorZaGa wants to merge 1 commit into
Peterodox:mainfrom
HectorZaGa:main
Open

Feature: Add Dragonflight Expansion Summary & TWW Delves tracking#465
HectorZaGa wants to merge 1 commit into
Peterodox:mainfrom
HectorZaGa:main

Conversation

@HectorZaGa

@HectorZaGa HectorZaGa commented Jul 14, 2026

Copy link
Copy Markdown

This pull request adds support for the Dragonflight expansion in the Expansion Summary page and makes a few layout improvements for The War Within.

Key Changes:

  • Dragonflight Summary: Registered expansion ID 10 to enable the UI toggle button.
  • Faction Layout & Colors: Configured custom progress bar colors and subfaction 3D portraits (Sabellian, Wrathion, Soridormi) for all major DF factions in FactionUtil.lua.
  • Weekly Activities: Added a new DF_Activity.lua module to track major weekly events (Aiding the Accord, Community Feast, Siege on Dragonbane Keep, Researchers Under Fire, etc.).
  • Resources & Raids: Registered DF currencies (Dragon Isles Supplies, Flightstones, etc.) and Raid encounters (Vault of the Incarnates, Aberrus, Amirdrassil).
  • Sprite Coordinates: Re-mapped FACTION_ICONS_COORDS in Basic.lua to cleanly accommodate the Dragonflight texture atlas on Row 1, safely shifting TWW and Midnight rows down to prevent hover highlight overlapping.
  • TWW Improvements: Added Delves tracking to the TWW layout, including companion level tracking for Brann Bronzebeard (creatureDisplayID 115505).

This pull request adds support for the Dragonflight expansion in the Expansion Summary page and makes a few layout improvements for The War Within.

Key Changes:

Dragonflight Summary: Registered expansion ID 10 to enable the UI toggle button.
Faction Layout & Colors: Configured custom progress bar colors and subfaction 3D portraits (Sabellian, Wrathion, Soridormi) for all major DF factions in FactionUtil.lua.
Weekly Activities: Added a new DF_Activity.lua module to track major weekly events (Aiding the Accord, Community Feast, Siege on Dragonbane Keep, Researchers Under Fire, etc.).
Resources & Raids: Registered DF currencies (Dragon Isles Supplies, Flightstones, etc.) and Raid encounters (Vault of the Incarnates, Aberrus, Amirdrassil).
Sprite Coordinates: Re-mapped FACTION_ICONS_COORDS in Basic.lua to cleanly accommodate the Dragonflight texture atlas on Row 1, safely shifting TWW and Midnight rows down to prevent hover highlight overlapping.
TWW Improvements: Added Delves tracking to the TWW layout, including companion level tracking for Brann Bronzebeard (creatureDisplayID 115505).
Copilot AI review requested due to automatic review settings July 14, 2026 02:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Dragonflight (expansionID 10) support to the Expansion Landing Page by registering DF-specific resources, weekly activities, faction layouts/colors, and raid encounter journal instances, while also extending existing TWW faction layout to include Delves companion tracking and updating faction icon atlas coordinates to accommodate DF icons.

Changes:

  • Register Dragonflight expansion data for resources, activities, factions, and encounters.
  • Update faction icon atlas coordinates and expansion selection list to include DF.
  • Extend TWW faction layout with Delves S3 + Brann companion subfaction tracking.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Modules/ExpansionLandingPage/Retail/ResourceList.lua Adds DF currency/resource list and registers it under expansionID 10.
Modules/ExpansionLandingPage/Retail/DF_Activity.lua Introduces DF weekly activity tracking data and registers it for expansionID 10.
Modules/ExpansionLandingPage/FactionUtil.lua Adds DF faction colors/layouts, adds TWW Delves S3 subfaction for Brann, and includes DF in reward-pending scan.
Modules/ExpansionLandingPage/ExpansionLandingPage_Retail.xml Loads the new DF activity script module.
Modules/ExpansionLandingPage/EncounterData.lua Registers DF raid instance IDs for encounter tracking under expansionID 10.
Modules/ExpansionLandingPage/Basic.lua Remaps faction icon atlas coords to include DF and updates expansion selection data/list to include DF.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +2 to +3
local API = addon.API;
local LandingPageUtil = addon.LandingPageUtil;
entries = {
{name = "Siege on Dragonbane Keep", questID = 71210, isWeeklyQuest = true},
{name = "Wanted: Fenistrasza's Skull", questID = 70995, isWeeklyQuest = true},
{name = "Wanted: Earthbound Primordial Core", questID = 71001, isWeeklyQuest = true},
Comment on lines +157 to +159
[2640] = { --Brann Bronzebeard
barColor = {1/255, 185/255, 27/255},
},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants