Feat/recordbrowser by nicolasp025 · Pull Request #33 · Pharo-XP-Tools/DebuggingSpy

nicolasp025 · 2026-02-20T15:05:11Z

No description provided.

feat: adding records to browser

feat: displaying history on tree table

feat: open history when adding a file

feat: DSSpy button & start/stop buttons on toolbar

fix: using now only one instance of browser refactor: renaming package

fix: error when opening timeline with not enough data

fix: timer that was not counting the seconds refactor: DSRecordBrowserPresenter => DSRecordBrowser refactor: some methods from browser going into the browser class doc: updating the documentation for browser

Fix/recordbrowser

Julesboul

Don't be affraid with the number of comments: many are repeated and it is common in reviews!

In general, this is a good code and this browser will be a great feature to add.

Pay attention to segmentation: the more your code is segmented, the best it is for testing and finding bugs.

DebuggingSpy/DSAbstractDebuggerActionRecord.class.st

DebuggingSpy/DSAbstractDebugPointEventRecord.class.st

DebuggingSpy/DSAbstractExtendedRecord.class.st

DebuggingSpy/DSAbstractHaltRecord.class.st

DebuggingSpy/DSAbstractSindarinActionRecord.class.st

DebuggingSpy-Browser-Tests/DSRecordBrowserTest.class.st

feat: adding more tests for each browser feature refactor: removing ColoredRecord class; refactoring comment: adding more comments where needed

Julesboul · 2026-03-03T09:21:52Z

DebuggingSpy-Browser/DSTimerWindow.class.st

@@ -0,0 +1,153 @@
+"
+This class is a window displaying some informations while DebuggingSpy is recording.


Suggested change

This class is a window displaying some informations while DebuggingSpy is recording.

I am a window displaying timer while DebuggingSpy is recording.

It is just a timer finally, isn't it?

Julesboul · 2026-03-03T09:25:14Z

DebuggingSpy-Browser/DSTimerWindow.class.st

+
+{ #category : 'initialization' }
+DSTimerWindow >> buildUI [
+	"Builds the windows UI that contains : an icon that shows that Debugging Spy is recording, a chronometer, a timer that shows actual time and a stop recording button."


Suggested change

"Builds the windows UI that contains : an icon that shows that Debugging Spy is recording, a chronometer, a timer that shows actual time and a stop recording button."

"Builds the windows UI, it contains : an icon which shows that Debugging Spy is recording, a chronometer, a timer with current time and a stop recording button."

For your information, the definition of actual : https://dictionary.cambridge.org/dictionary/english/actual

Julesboul · 2026-03-03T09:33:30Z

DebuggingSpy-Browser/DSTimerWindow.class.st

+DSTimerWindow >> initializeProperties [
+
+	self
+		setLabel: 'DSSpy recorder';


Suggested change

setLabel: 'DSSpy recorder';

setLabel: 'DSSpy Timer';

I guess that the label should display what the object is? Or maybe it is something else

Julesboul · 2026-03-03T09:37:54Z

DebuggingSpy-Browser/DSTimerWindow.class.st

+]
+
+{ #category : 'layout' }
+DSTimerWindow >> timeNowMorph [


Suggested change

DSTimerWindow >> timeNowMorph [

DSTimerWindow >> currentTimeMorph [

It is a detail, the other name is also ok

Julesboul · 2026-03-03T09:52:57Z

DebuggingSpy-Browser/DSTimerWindow.class.st

+DSTimerWindow >> collapseOrExpand [
+
+	^ self
+]


This method is here to not allow users to collapse or expand? It is just to be sure

Julesboul · 2026-03-03T12:38:09Z

DebuggingSpy-Browser-Tests/DSRecordBrowserTest.class.st

+]
+
+{ #category : 'tests' }
+DSRecordBrowserTest >> testBrowserEmpty [


What about the recordsTablePrensenter in this case? How should it be?

Julesboul · 2026-03-03T12:45:38Z

DebuggingSpy-Browser-Tests/DSRecordBrowserTest.class.st

+	history windows do: [ :window |
+			window events do: [ :record |
+					self assert: (colorAssociations anySatisfy: [ :association |
+							 association key = record and: association value = (browser getWindowColorFrom: window) ]) ] ]


Suggested change

association key = record and: association value = (browser getWindowColorFrom: window) ]) ] ]

association key = record and: [association value = (browser getWindowColorFrom: window) ] ]) ] ]

Julesboul · 2026-03-03T12:46:08Z

DebuggingSpy-Browser-Tests/DSRecordBrowserTest.class.st

+]
+
+{ #category : 'tests' }
+DSRecordBrowserTest >> testGetRecordColorAssociationsFrom [


This test is not clear for me, can you explain it?

By the way, as you want to check that different colors appears in your presenter, it will be interesting to have different type of records in your testing file

Julesboul · 2026-03-03T12:48:46Z

DebuggingSpy-Browser-Tests/DSRecordBrowserTest.class.st

+	self assert: DSRecordRegistry autoSerialize.
+	self deny: browser recorderWindow isNil.
+
+	browser stopRecording


You can check is the timerWindow is closed after stopping the recording, and maybe some other things

Julesboul · 2026-03-03T12:53:25Z

DebuggingSpy-Browser-Tests/DSRecordBrowserTest.class.st

+]
+
+{ #category : 'tests' }
+DSRecordBrowserTest >> testFilteringAllRecords [


I think that, for this test, it will be interessing to have an example file with different type of record (as you want to filter records).

Julesboul

That's good to see more tests and the way of generating a testing file is really better than before!

There are still few things to change and some careless mistakes.

nicolasp025 added 24 commits February 5, 2026 13:12

d0dad6b

feat: adding records to browser

8b1479c

feat: displaying history on tree table

23ec5e0

feat: open history when adding a file

486cfed

feat: DSSpy button & start/stop buttons on toolbar

feat: adding a recorder window

f911360

fix: using now only one instance of browser refactor: renaming package

feat: can inspect records on right click

ea04d1d

feat: more info on recorder window and stop button

f31aa6c

fix: could not hide with taskbar, also adding window icon

0f39f0e

feat: can inspect records in browser

a8720ec

feat: colored records on browser

9f3f530

fix: column for color in browser

5321071

feat: new colors for browser

819f0b0

fix: cannot add a file twice

1af3591

feat: timeline chart (data need to be fixed, also need refactoring)

c3b5de3

feat: dynamic colors for timeline

5cd5eb8

fix: refactoring and display plots with nanoseconds

70a8d12

refactoring: remove buttons attributes in browser class

a44b70a

feat: adding a method for getting all record classes

0ae7e5c

feat: filter the records

305073b

fix: error when opening timeline with not enough data

refactoring: records table and text color always white

318ba65

feat: inspect record in table when selected

9f8477e

fix: on record inspect

fa08e33

test: for the browser and the recorder

e5a6b5c

fix: timer that was not counting the seconds refactor: DSRecordBrowserPresenter => DSRecordBrowser refactor: some methods from browser going into the browser class doc: updating the documentation for browser

refactoring: DSRecordBrowserPresenter -> DSRecordBrowser

8ad83d9

Julesboul requested review from Julesboul and StevenCostiou and removed request for StevenCostiou February 20, 2026 15:07

Julesboul assigned nicolasp025 Feb 20, 2026

fix: adding browser tests to baseline

a7d8bbc

nicolasp025 added 3 commits February 23, 2026 14:01

fix: browser testing

9838a45

refacto: browser lazy init and test fixes

bece7be

fix: auto serialize and instrumentation after opening the recorder

23ded92

nicolasp025 marked this pull request as ready for review February 23, 2026 14:31

nicolasp025 marked this pull request as draft February 23, 2026 15:46

nicolasp025 and others added 4 commits February 24, 2026 10:30

fix: browser tests and git rebase

11e058a

fix: recorder window was opened but never closed in tests

9fd34a5

Merge branch 'feature/recordbrowser' into fix/recordbrowser

c41e740

Merge pull request #1 from nicolasp025/fix/recordbrowser

d7c4d3b

Fix/recordbrowser

nicolasp025 marked this pull request as ready for review February 24, 2026 10:31

Julesboul requested changes Feb 25, 2026

View reviewed changes

nicolasp025 added 2 commits March 2, 2026 14:52

fix: update with PR changes

4cf47b1

feat: adding more tests for each browser feature refactor: removing ColoredRecord class; refactoring comment: adding more comments where needed

fix: in browser opening/closing tests

ebc3aba

nicolasp025 requested a review from Julesboul March 2, 2026 15:06

Julesboul requested changes Mar 3, 2026

View reviewed changes

		@@ -0,0 +1,153 @@
		"
		This class is a window displaying some informations while DebuggingSpy is recording.

	This class is a window displaying some informations while DebuggingSpy is recording.
	I am a window displaying timer while DebuggingSpy is recording.

	"Builds the windows UI that contains : an icon that shows that Debugging Spy is recording, a chronometer, a timer that shows actual time and a stop recording button."
	"Builds the windows UI, it contains : an icon which shows that Debugging Spy is recording, a chronometer, a timer with current time and a stop recording button."

	DSTimerWindow >> timeNowMorph [
	DSTimerWindow >> currentTimeMorph [

	association key = record and: association value = (browser getWindowColorFrom: window) ]) ] ]
	association key = record and: [association value = (browser getWindowColorFrom: window) ] ]) ] ]

Conversation

nicolasp025 commented Feb 20, 2026

Uh oh!

Julesboul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julesboul left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants