Skip to content

MFG Data fix on android#619

Open
ghost wants to merge 3 commits intoPhilipsHue:masterfrom
biiitech:master
Open

MFG Data fix on android#619
ghost wants to merge 3 commits intoPhilipsHue:masterfrom
biiitech:master

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 16, 2022

BLE Spec allows sending MFG data of more than 24 bytes by adding MFG data fields in the scan response packet, by default iOS concat it but android doesn't thus we manually concat mfg data spreaded across multiple packets

@ghost ghost closed this Oct 16, 2022
@ghost ghost reopened this Oct 16, 2022
@Taym95
Copy link
Copy Markdown
Collaborator

Taym95 commented Nov 2, 2022

Thanks lot for contribution, I will make sure to review this week!

@Taym95
Copy link
Copy Markdown
Collaborator

Taym95 commented Dec 12, 2022

CI is failing

Append MFG data of Advertising and ScanResponse Packet.
By Spec Ble allows sending MFG data of more than 24 bytes by adding MFG data fields in the scan response packet, by default iOS concat it but android doesn't thus we manually concat mfg data spreaded across multiple packets
@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 13, 2022

@Taym95
CI/CD passed after rebase, earlier it failed due to the XCode version requirement.
Ready for review

@nataddrho
Copy link
Copy Markdown

This issue is exactly where I am stuck. I developed a small sensor that sends proprietary data on both the advertisement and scan response packets. The advantage of doing this is that the sensor is transmit only and multiple observers can see the sensor simultaneously, a requirement.

Currently the scan response data over-writes the advertisement data, and all I see from the device is:

I/flutter ( 9444): DiscoveredDevice(id: EA:3B:31:D2:73:E8, name: , serviceData: {}, serviceUuids: [], manufacturerData: [222, 3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], rssi: -71)

I should be seeing two arrays of this size.

Flutter Blue Plus has the same problem.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 28, 2023

@Taym95 Any update on this?

@Taym95
Copy link
Copy Markdown
Collaborator

Taym95 commented Jan 17, 2024

@biii-anuj-pathak can you please rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants