Skip to content

feat(Footer): L3-6892 Change footer links and copy to sentence case#890

Open
zhenpanda wants to merge 1 commit into
mainfrom
L3-6892-Change-footer-links-and-copy-to-sentence-case
Open

feat(Footer): L3-6892 Change footer links and copy to sentence case#890
zhenpanda wants to merge 1 commit into
mainfrom
L3-6892-Change-footer-links-and-copy-to-sentence-case

Conversation

@zhenpanda

Copy link
Copy Markdown
Contributor

Jira ticket

Jira Ticket ID

Screenshots

Screenshot 2026-07-10 at 11 40 25 AM

Summary

Update footer links and copy to sentence case

Change List (describe the changes made to the files)

Acceptance Test (how to verify the PR)

  • Add step by step instructions on how to verify the change

Regression Test

  • (Optional) Add verification steps to make sure this PR doesn't break old functionality

Evidence of testing

  • Post logs, screenshots, etc

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

Copilot AI review requested due to automatic review settings July 10, 2026 15:41
@netlify

netlify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit df069eb
🔍 Latest deploy log https://app.netlify.com/projects/phillips-seldon/deploys/6a5112b0fe89bf00085af9f2
😎 Deploy Preview https://deploy-preview-890--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SiteFurniture Footer presentation to use sentence case in Storybook examples and removes uppercase styling applied via the linkStylised typography token for the mobile accordion labels.

Changes:

  • Updated mobile accordion section labels in Footer Storybook to sentence case (“About us”, “Our services”).
  • Updated footer accordion label styling to explicitly disable uppercase (text-transform: none) and removed the redundant mobile-only override.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/site-furniture/Footer/Footer.stories.tsx Adjusts footer section labels in the Storybook example to sentence case.
src/site-furniture/Footer/_footer.scss Ensures accordion label text renders in sentence case by overriding the uppercase transform from linkStylised, and removes the no-longer-needed mobile-specific block.

@chromatic-com

chromatic-com Bot commented Jul 10, 2026

Copy link
Copy Markdown

Important

UI Tests need review – Review now

🟡 UI Tests: 1 visual and accessibility change must be accepted as baseline
🟡 UI Review: Awaiting 3 approvals
Storybook icon Storybook Publish: 232 stories published

@github-actions

Copy link
Copy Markdown

@DaveMcNamara DaveMcNamara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linkStylised

what redcoat is responsible for this??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants