Skip to content

feat(chore): L3-00000 update node version to v22.23.1#893

Merged
constantinehuzenko merged 2 commits into
mainfrom
L3-00000-update-node-version
Jul 14, 2026
Merged

feat(chore): L3-00000 update node version to v22.23.1#893
constantinehuzenko merged 2 commits into
mainfrom
L3-00000-update-node-version

Conversation

@constantinehuzenko

@constantinehuzenko constantinehuzenko commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Jira ticket

L3-00000

Screenshots

N/A — config-only change, no UI impact.

Figma link

N/A

Summary

Bump the pinned Node version in .nvmrc from v22.22.0 to v22.23.1 (latest 22.x LTS patch release). We hit the Node 20 deprecation, so we need to update the pinned Node version to stay on a supported release.

Change List (describe the changes made to the files)

  • .nvmrc: updated Node version from v22.22.0 to v22.23.1

Acceptance Test (how to verify the PR)

  • Run nvm use in the repo root and confirm it activates Node v22.23.1
  • Confirm CI passes on this branch

Regression Test

  • Run npm ci && npm run build locally on Node v22.23.1 and confirm the build succeeds

Evidence of testing

  • Pre-commit hooks (tsc, eslint, stylelint, markdownlint, prettier) ran and passed on commit

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

🤖 Generated with Claude Code

Node 20 is deprecated, so bump the pinned Node version.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 14, 2026 18:11
@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit 59882e5
🔍 Latest deploy log https://app.netlify.com/projects/phillips-seldon/deploys/6a567c753a33d10009e75e6a
😎 Deploy Preview https://deploy-preview-893--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s pinned Node.js version via .nvmrc, intended to keep local development and CI aligned on a supported Node release.

Changes:

  • Bumped .nvmrc from v22.22.0 to v22.22.2.

Comment thread .nvmrc Outdated
@@ -1 +1 @@
v22.22.0
v22.22.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good point, if irrelevant to this PR

@chromatic-com

chromatic-com Bot commented Jul 14, 2026

Copy link
Copy Markdown

Important

Testing in progress…

🟢 UI Tests: 464 tests unchanged
UI Review: Comparing 232 stories…
Storybook icon Storybook Publish: 232 stories published

@chromatic-com

chromatic-com Bot commented Jul 14, 2026

Copy link
Copy Markdown

Tip

All tests passed and all changes approved!

🟢 UI Tests: 464 tests unchanged
🟢 UI Review: 232 stories published -- no changes
Storybook icon Storybook Publish: 232 stories published

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

Use the latest 22.x LTS patch release.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@constantinehuzenko constantinehuzenko changed the title chore: L3-00000 update node version to v22.22.2 chore: L3-00000 update node version to v22.23.1 Jul 14, 2026
@constantinehuzenko constantinehuzenko changed the title chore: L3-00000 update node version to v22.23.1 feat(chore): L3-00000 update node version to v22.23.1 Jul 14, 2026

@DaveMcNamara DaveMcNamara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only need to bump to 22.22.2 to fix the error, I'm assuming going up to LTS is fine too

@constantinehuzenko constantinehuzenko merged commit 88a9ddf into main Jul 14, 2026
16 of 18 checks passed
@constantinehuzenko constantinehuzenko deleted the L3-00000-update-node-version branch July 14, 2026 18:26
davidicus pushed a commit that referenced this pull request Jul 14, 2026
# [1.273.0](v1.272.0...v1.273.0) (2026-07-14)

### Features

* **chore:** L3-00000 update node version to v22.23.1 ([#893](#893)) ([88a9ddf](88a9ddf))
* **config:** L3-13449 declare package side-effect-free to enable consumer tree shaking ([#891](#891)) ([4016df6](4016df6))
@davidicus

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.273.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants