api: Add general method to make requests.#20
Open
fishinthecalculator wants to merge 1 commit intoPhillyDSA:developfrom
Open
api: Add general method to make requests.#20fishinthecalculator wants to merge 1 commit intoPhillyDSA:developfrom
fishinthecalculator wants to merge 1 commit intoPhillyDSA:developfrom
Conversation
fishinthecalculator
force-pushed
the
requests
branch
3 times, most recently
from
58c00bc to
55d86b5
Compare
fishinthecalculator
force-pushed
the
requests
branch
from
55d86b5 to
c6995aa
Compare
fishinthecalculator
force-pushed
the
requests
branch
from
c6995aa to
f7ec80b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a general method to make requests to a given API endpoint.
Motivation and Context
This allows methods in the
helpersmodule to avoid depending directly fromrequestsand to handle json deserialization.How Has This Been Tested?
I have been using this in my fork for some time
Types of changes
Checklist: