Update ZipScript, added a parameter for runing .exe installers inside archives#1074
Update ZipScript, added a parameter for runing .exe installers inside archives#1074plata merged 33 commits intoPhoenicisOrg:masterfrom
Conversation
Merged current master
Update the fork with changes from master fork.
Fork update
merge changes
Merging changes to the fork
Merging updates from master fork
Merging changes from master
Merge from master branch
|
Can you maybe test with some other free application so that we are not blocked by Photoshop? |
|
I could but I don't know any application other than Photoshop that would make use of ZipScript. |
madoar
left a comment
There was a problem hiding this comment.
@Zemogiter the script requires some formatting
Add a file existence check.
|
@madoar is this the check sufficient? |
|
I think you should invert the check, i.e. add behavior in case the file does not exist. I think ideally we should show an error message informing the user of the problem. |
|
@madoar done |
|
I get using this that |
|
Can you show the exact error message? I'm assuming that a prefix is lost at some point. |
plata
left a comment
There was a problem hiding this comment.
Did you check that both cases still work (with and without setup path)?
|
I do not have time to review currently. |
Description
In it's current shape, the
ZipScriptdosen't do much because there is no information regarding the .exe file inside archive.What works
to be filled
What was not tested
Nothing was tested yet, waiting for @ImperatorS79 to test this in his Adobe Photoshop script #1122
Test
Ready for review
json-alignandeslintrun according to the documentation.