Update Origin, using const instead of var and Resource instead of Downloader#1185
Open
Zemogiter wants to merge 34 commits intoPhoenicisOrg:masterfrom
Open
Update Origin, using const instead of var and Resource instead of Downloader#1185Zemogiter wants to merge 34 commits intoPhoenicisOrg:masterfrom
Zemogiter wants to merge 34 commits intoPhoenicisOrg:masterfrom
Conversation
Merged current master
Update the fork with changes from master fork.
Fork update
merge changes
Merging changes to the fork
Merging updates from master fork
Merging changes from master
Merge from master branch
Merge master fork
Updated the way virtual desktop plugin is used.
Merge master fork
Merge master fork
Collaborator
|
This PR should not contain "Heroes of Might & Magic IV". |
Contributor
Author
|
I don't know why there are files for Heroes 4 in this PR. |
plata
reviewed
Jan 5, 2020
Zemogiter
changed the title
Contributor
Author
|
Why is Travis stuck? |
Collaborator
|
Could be that it doesn't run on draft PRs. |
Collaborator
|
No it works on other draft releases. @Zemogiter please try pushing a change to the branch this should trigger a new build. |
Collaborator
|
@Zemogiter you have conflicts. |
Contributor
Author
|
@plata done |
Collaborator
|
@madoar did we come to any conclusion regarding Resource/Downloader now? In my opinion using Resource here is not correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #1177
What works
to be filled in
What was not tested
Everything
Test
Ready for review
json-alignandeslintrun according to the documentation.