Mark Assassin's Creed III as "testing" (Uplay not working)#984
Mark Assassin's Creed III as "testing" (Uplay not working)#984plata merged 3 commits intoPhoenicisOrg:masterfrom
Conversation
|
Failing to pass Travis-CI suspect false trigger. 🤔 |
|
Any idea why it does not work in Steam but in Uplay? For me this doesn't make sense. |
your provided example for uplay script has this sytax err i think it was sourced from there. |
The Steam script does not work because of a syntax error in the Uplay script? |
Travis ignores syntax error in uplay script which is same syntax err as in #989 -> suspecting it beeing relevant and definitions sourced from the docs. |
|
Please check Travis. There's an issue with json-align. See the docs. Note: this requirement is described in the pull request how-to in the README. |
plata
changed the title
| */ | ||
| Wine.prototype.faudio = function (faudioVersion) { | ||
| if(typeof faudioVersion !== 'string') | ||
| if (typeof faudioVersion !== 'string') |
There was a problem hiding this comment.
No reason to blame people who try to help you!
There was a problem hiding this comment.
@plata You blame ppl in linux if they do something wrong so that they know about it.. it's the way we QA each other and i encourage you to do the same.
There was a problem hiding this comment.
@Kreyren There is a big difference between destructive / personal attack and code review / constructive remarks and quality assurance. Please beware of it.
3 participants
As refferenced on #967 (comment) this script is not working -> push in testing